> On July 15, 2015, 10:31 p.m., Namit Maheshwari wrote: > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ClusterMerlin.java, > > line 181 > > <https://reviews.apache.org/r/36482/diff/1/?file=1011712#file1011712line181> > > > > Not clear about the complete context, but the code is just changing the > > value for property with similar names. It is not changing the name of the > > property. Is this what we wanted to do here? > > Raghav Gautam wrote: > As of now in the entity properties, it is possible to have two property > with same name. This is confusing. If a property with same name exists, the > value is overwritten else a new property is added.
Got that point. But do we not want to change the code, such that we do not add properties with same name, rather than just changing the value for one property. - Namit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36482/#review91829 ----------------------------------------------------------- On July 14, 2015, 7:47 p.m., Raghav Gautam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36482/ > ----------------------------------------------------------- > > (Updated July 14, 2015, 7:47 p.m.) > > > Review request for Falcon. > > > Bugs: falcon-1278 > https://issues.apache.org/jira/browse/falcon-1278 > > > Repository: falcon-git > > > Description > ------- > > falcon-1278: Submitted entity properties must have unique names > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ClusterMerlin.java > 0198e19cd0c34109244e4e0baea5f9f85b5f0a5a > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java > 787ddc14c1d606055c928ce822d31f7117951ddd > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java > 615587de523396dc161b9084b9654ad0c195b289 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java > c8f2320e98d889ba221a22fd27f25b2b0e8a7084 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java > bda5c2302b898289668511e583cd8e376f7526e7 > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java > cb6315b76755eb1f3600adf42529ebee433aa1f9 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java > e09033f00a4d310648f90a82a62423af75893b7f > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/EmbeddedPigScriptTest.java > 4fb3c4a8f117ba43c96966cc9509142106d15321 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/LogMoverTest.java > 56fe8ab00616efa5f72260f0e064e72de07a2c2e > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/EntityDryRunTest.java > 529df25f7a909d67b5957431791e01cee65d1b71 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/FeedDelayTest.java > e43621aba4f6b0ff71eafbf0d5fc075675b53917 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java > 35806fd299ca75fd8e3c05697e3effe2f3c924bc > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/ProcessPartitionExpVariableTest.java > 20c60d24eab37c1f1bdbc8995962a99047f857cf > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/UpdateAtSpecificTimeTest.java > 189ef2fa34427676a684629fa7cb0d4cff968e04 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FeedAclTest.java > 6144c69efb99b9eafd0a5c6f5d5ac4041fc492ec > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ProcessAclTest.java > b649915be238f0dbef00c46d6ede8c2a289d949f > > Diff: https://reviews.apache.org/r/36482/diff/ > > > Testing > ------- > > EmbeddedPigScriptTest ran and passed. > > > Thanks, > > Raghav Gautam > >
