----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36538/#review92394 -----------------------------------------------------------
common/src/main/java/org/apache/falcon/entity/EntityUtil.java (line 349) <https://reviews.apache.org/r/36538/#comment146544> Do you want me create DateUtil class ? As it is not there as of now. common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java (line 98) <https://reviews.apache.org/r/36538/#comment146545> sure will do common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java (line 107) <https://reviews.apache.org/r/36538/#comment146546> Will fix it . Even reloading can also be avoided common/src/main/java/org/apache/falcon/workflow/util/OozieConstants.java (line 1) <https://reviews.apache.org/r/36538/#comment146547> Yes anticipating lot of constants will come. We need this in commons module where all other modules can access . ProxyOozie client is in prism module not every other has dependency on it hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java (line 61) <https://reviews.apache.org/r/36538/#comment146548> Agreed. Thats why data is in always target directory. Still will also add falcon to the target directory oozie/src/main/java/org/apache/oozie/client/LocalOozieClientBundle.java (line 57) <https://reviews.apache.org/r/36538/#comment146549> sure will do oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java (line 75) <https://reviews.apache.org/r/36538/#comment146557> Even run function is there for client , coord and bundle , even basic version we used only for bundle . Later we can differentiate it oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java (line 121) <https://reviews.apache.org/r/36538/#comment146550> This method exists in both, but we are using Coord one oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java (line 127) <https://reviews.apache.org/r/36538/#comment146551> This method exists in both , but we are using only coord in basic falcon unit version . We should handle this properly in later versions unit/src/main/java/org/apache/falcon/unit/FalconUnit.java (line 50) <https://reviews.apache.org/r/36538/#comment146552> Even i think the same , since cluster mode support also exists i named it FalconUnit unit/src/main/java/org/apache/falcon/unit/FalconUnit.java (line 69) <https://reviews.apache.org/r/36538/#comment146558> Sure will fix it unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java (line 45) <https://reviews.apache.org/r/36538/#comment146554> Sure will create Interface make both override that unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java (line 47) <https://reviews.apache.org/r/36538/#comment146555> Only Reason is it supports in cluster mode also. unit/src/main/java/org/apache/falcon/unit/LocalFalconClientProtocolProvider.java (line 56) <https://reviews.apache.org/r/36538/#comment146553> sure will fix it . unit/src/main/resources/deploy.properties (line 18) <https://reviews.apache.org/r/36538/#comment146559> sure will do it unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java (line 112) <https://reviews.apache.org/r/36538/#comment146560> sure will add colo and cluster separately and properties map for other props unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java (line 258) <https://reviews.apache.org/r/36538/#comment146561> sure will do it. Thanks unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 39) <https://reviews.apache.org/r/36538/#comment146562> sure unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 42) <https://reviews.apache.org/r/36538/#comment146565> sure will do it . Thanks unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 51) <https://reviews.apache.org/r/36538/#comment146563> Predicate will get timedout if it is not succedded until threshold time. Thats why checking again unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 53) <https://reviews.apache.org/r/36538/#comment146564> sure will fix it - pavan kumar kolamuri On July 16, 2015, 5:41 a.m., Pallavi Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36538/ > ----------------------------------------------------------- > > (Updated July 16, 2015, 5:41 a.m.) > > > Review request for Falcon and Pallavi Rao. > > > Repository: falcon-git > > > Description > ------- > > Submitted to Review Board on behalf of Pavan as he is on vacation for the 3 > days. > > Falcon unit will be able to help to validate the process, feed and cluster > xml's and as well as workflows of oozie. It will also help to submit schedule > of jobs and check the job status as well. Falcon Unit supports two modes > 1) Local Mode : It will bring up local oozie , use local file system and uses > Local Job Runner to run the jobs > 2) Cluster Mode: Falcon unit Api's can also be run by pointing to external > oozie, hdfs and jobtracker. > Documentation of falcon unit is provided in > https://issues.apache.org/jira/browse/FALCON-1296 > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/EntityUtil.java 63dfb9d > > common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java > 59b0910 > common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java > b5f531a > common/src/main/java/org/apache/falcon/workflow/util/OozieConstants.java > PRE-CREATION > > hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java > 7156bbd > oozie/src/main/java/org/apache/falcon/oozie/OozieBundleBuilder.java 03063f4 > > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieClientFactory.java > 622238a > > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java > 4085b8f > oozie/src/main/java/org/apache/oozie/client/LocalOozieClientBundle.java > PRE-CREATION > oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java > PRE-CREATION > pom.xml 31997e8 > unit/pom.xml PRE-CREATION > unit/src/main/java/org/apache/falcon/unit/FalconUnit.java PRE-CREATION > unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java > PRE-CREATION > unit/src/main/java/org/apache/falcon/unit/FalconUnitHelper.java > PRE-CREATION > > unit/src/main/java/org/apache/falcon/unit/LocalFalconClientProtocolProvider.java > PRE-CREATION > > unit/src/main/resources/META-INF/services/org.apache.hadoop.mapreduce.protocol.ClientProtocolProvider > PRE-CREATION > unit/src/main/resources/core-site.xml PRE-CREATION > unit/src/main/resources/deploy.properties PRE-CREATION > unit/src/main/resources/localoozie-log4j.properties PRE-CREATION > unit/src/main/resources/log4j.xml PRE-CREATION > unit/src/main/resources/mapred-site.xml PRE-CREATION > unit/src/main/resources/oozie-site.xml PRE-CREATION > unit/src/main/resources/startup.properties PRE-CREATION > unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java > PRE-CREATION > unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java PRE-CREATION > unit/src/test/java/org/apache/falcon/unit/examples/JavaExample.java > PRE-CREATION > unit/src/test/resources/cluster-template.xml PRE-CREATION > unit/src/test/resources/infeed.xml PRE-CREATION > unit/src/test/resources/input.txt PRE-CREATION > unit/src/test/resources/outfeed.xml PRE-CREATION > unit/src/test/resources/process.xml PRE-CREATION > unit/src/test/resources/workflow.xml PRE-CREATION > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java > 47b51fe > > webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java > 6e58064 > webapp/src/test/java/org/apache/falcon/util/OozieTestUtils.java 02d1011 > > Diff: https://reviews.apache.org/r/36538/diff/ > > > Testing > ------- > > > Thanks, > > Pallavi Rao > >
