> On July 24, 2015, 6:30 a.m., pavan kumar kolamuri wrote: > > prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java, > > line 104 > > <https://reviews.apache.org/r/36758/diff/1/?file=1020519#file1020519line104> > > > > Can i know the reason why null condition check added ? It will take > > default value when this param is not passed right ?
There is no default value specified for numResults any longer. - Ajay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36758/#review92873 ----------------------------------------------------------- On July 24, 2015, 12:46 a.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36758/ > ----------------------------------------------------------- > > (Updated July 24, 2015, 12:46 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1324 > https://issues.apache.org/jira/browse/FALCON-1324 > > > Repository: falcon-git > > > Description > ------- > > Currently pagination API breaks backward compatibility as it by default > returns 10 results. For example, earlier > falcon entity -type feed -list > used to return all the feeds but now the same command will return only 10 > results. > > Proposed solution: > We should make the default number of results configurable in the properties > file and put it to a high value by default so that behavior is backwards > compatible. > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java e393f82 > client/src/main/java/org/apache/falcon/client/FalconClient.java 555bdb7 > common/src/main/resources/runtime.properties 3b32463 > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java > a3801e9 > prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java > 310e73b > > prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java > ac3e5db > > prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java > eb281d3 > src/conf/runtime.properties 58dee3d > webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java > 9c5538b > > webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java > ed6f44e > > Diff: https://reviews.apache.org/r/36758/diff/ > > > Testing > ------- > > > Thanks, > > Ajay Yadava > >
