-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36812/#review93071
-----------------------------------------------------------



prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java
 (line 234)
<https://reviews.apache.org/r/36812/#comment147330>

    An exception used to get thrown in case there is a failure/partial success. 
So, in case of errors, the code doesn't even reach here. 
    
    Now, we don't throw an exception on partial failures and additionally check 
for the success status.
    
    The additional status check is good. But, I don't understand how it 
addresses the issue.


- Pallavi Rao


On July 25, 2015, 11:47 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36812/
> -----------------------------------------------------------
> 
> (Updated July 25, 2015, 11:47 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1329
>     https://issues.apache.org/jira/browse/FALCON-1329
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> In certain cases Idempotent behaviour of falcon is broken. Sometimes, 
> entities go in a zombie state.
> 
> 
> Diffs
> -----
> 
>   prism/src/main/java/org/apache/falcon/resource/channel/HTTPChannel.java 
> 3d3a58a 
>   
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java
>  eb281d3 
> 
> Diff: https://reviews.apache.org/r/36812/diff/
> 
> 
> Testing
> -------
> 
> Manually tested in distributed mode. Unit tests or integration tests for this 
> are not possible.
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Reply via email to