> On July 22, 2015, 12:42 p.m., Ajay Yadava wrote: > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/EntityLineageUtil.java, > > line 39 > > <https://reviews.apache.org/r/36655/diff/1/?file=1018165#file1018165line39> > > > > Why is this required?
Since this is a utility class so made the constructor private and class final so as to restrict class object insatntiation. - PRAGYA ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36655/#review92587 ----------------------------------------------------------- On July 21, 2015, 8:50 p.m., PRAGYA MITTAL wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36655/ > ----------------------------------------------------------- > > (Updated July 21, 2015, 8:50 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1321 > https://issues.apache.org/jira/browse/FALCON-1321 > > > Repository: falcon-git > > > Description > ------- > > Add entity lineage test with failed and passed scenarios. Related to > https://issues.apache.org/jira/browse/FALCON-256 > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java > ae5c70c > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java > 50d7439 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/ServiceResponse.java > 175bb98 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/EntityLineageUtil.java > PRE-CREATION > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java > c220215 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/RequestKeys.java > b2e38b2 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntityLineageTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/36655/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > PRAGYA MITTAL > >
