> On Aug. 18, 2015, 4:15 a.m., Pallavi Rao wrote: > > common/src/main/java/org/apache/falcon/entity/v0/EntityGraph.java, line 64 > > <https://reviews.apache.org/r/37554/diff/1/?file=1042511#file1042511line64> > > > > The assert statement above does exactly this. We should either keep the > > assert statement and enable assertion (don't see why we shouldn't do that) > > or have the null the check the usual way. Don't need both.
Yes, we don't need the assert statement anymore, removed it. We shouldn't enable asserts as they are debugging aid and not meant for error handling. This is the same reason that they are by default disabled. - Ajay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37554/#review95685 ----------------------------------------------------------- On Aug. 18, 2015, 7:18 a.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37554/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2015, 7:18 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1344 > https://issues.apache.org/jira/browse/FALCON-1344 > > > Repository: falcon-git > > > Description > ------- > > Since falcon doesn't do any validation of the definitions on restart, in some > scenarios EntityGraph can contain dependencies which might not be present in > ConfigurationStore. In such scenarios EntityGraph returns null among the list > of dependent entities. This causes undesired side effects like this issue and > FALCON-1331. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/v0/EntityGraph.java 444e28d > > Diff: https://reviews.apache.org/r/37554/diff/ > > > Testing > ------- > > > Thanks, > > Ajay Yadava > >
