----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37750/#review96310 -----------------------------------------------------------
client/src/main/java/org/apache/falcon/cli/FalconCLI.java (line 602) <https://reviews.apache.org/r/37750/#comment151629> While you are at it, can you also change this line to explicitly say that the filterType is not valid? client/src/main/java/org/apache/falcon/cli/FalconCLI.java (line 605) <https://reviews.apache.org/r/37750/#comment151630> Would be more informative if said - "Invalid filterBy argument : " + tempKeyVal[0] + " in : " + s - Pallavi Rao On Aug. 25, 2015, 6:45 a.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37750/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2015, 6:45 a.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > Filter By: > Filter By throws wrong error in case of wrong argument being passed > falcon entity -list -type process -nameseq U -filterBy state > ERROR: Invalid filterBy argument : filterBy > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java 11f6bff > > Diff: https://reviews.apache.org/r/37750/diff/ > > > Testing > ------- > > Done > > > Thanks, > > Narayan Periwal > >
