> On Aug. 27, 2015, 9:04 p.m., Balu Vellanki wrote: > > > > Balu Vellanki wrote: > The rest of the patch looks good. Patch applied and built successfully > using command "mvn clean verify assembly:assembly -Phadoop-2,test-patch" > > Balu Vellanki wrote: > It would helpful to update docs for restAPI twiki at > docs/src/site/twiki/restapi/ as well.
Since there are many twiki for Rest API's plannign to do as part of diff jira so that I dont clutter this jira. This jira more focussed on code changes. I will create a new jira for Rest PAI documentation. > On Aug. 27, 2015, 9:04 p.m., Balu Vellanki wrote: > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java, line 536 > > <https://reviews.apache.org/r/37771/diff/2/?file=1055670#file1055670line536> > > > > Why was the getColo(colo) removed for TOUCH_OPT? I had to merge my code changes after FALCON-1174. Merge error, thanks for catching! > On Aug. 27, 2015, 9:04 p.m., Balu Vellanki wrote: > > common/src/main/java/org/apache/falcon/service/ProxyUserService.java, line 8 > > <https://reviews.apache.org/r/37771/diff/2/?file=1055677#file1055677line8> > > > > License is added twice. Please remove. ok. > On Aug. 27, 2015, 9:04 p.m., Balu Vellanki wrote: > > common/src/main/java/org/apache/falcon/service/ProxyUserService.java, line > > 97 > > <https://reviews.apache.org/r/37771/diff/2/?file=1055677#file1055677line97> > > > > Looks like debug logs are still in the code, please remove. Missed it, will remove. > On Aug. 27, 2015, 9:04 p.m., Balu Vellanki wrote: > > prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java, > > line 490 > > <https://reviews.apache.org/r/37771/diff/2/?file=1055688#file1055688line490> > > > > It is better if DefaultValue is not set and if code can handle null > > doAs user. Done - Sowmya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37771/#review96728 ----------------------------------------------------------- On Aug. 27, 2015, 2:41 a.m., Sowmya Ramesh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37771/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 2:41 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1027 > https://issues.apache.org/jira/browse/FALCON-1027 > > > Repository: falcon-git > > > Description > ------- > > Today, Falcon doesn’t have doAs capability i.e. it doesn’t support > impersonation. Support for impersonation or proxyuser functionality > (identical to Hadoop proxyuser capabilities and conceptually similar to Unix > 'sudo') needs to be added to REST API’s and CLI(Command > line). > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java 11dfe72 > client/src/main/java/org/apache/falcon/cli/FalconMetadataCLI.java 2f57c7d > client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java > 282b41b > client/src/main/java/org/apache/falcon/client/FalconClient.java 44436d2 > common/src/main/java/org/apache/falcon/security/CurrentUser.java 4aed5d7 > common/src/main/java/org/apache/falcon/security/SecurityUtil.java 861f80f > common/src/main/java/org/apache/falcon/service/GroupsService.java > PRE-CREATION > common/src/main/java/org/apache/falcon/service/ProxyUserService.java > PRE-CREATION > common/src/main/resources/startup.properties c48188c > common/src/test/java/org/apache/falcon/security/CurrentUserTest.java > 9a3f365 > common/src/test/java/org/apache/falcon/security/SecurityUtilTest.java > 6e77462 > common/src/test/java/org/apache/falcon/service/GroupsServiceTest.java > PRE-CREATION > common/src/test/java/org/apache/falcon/service/ProxyUserServiceTest.java > PRE-CREATION > docs/src/site/twiki/FalconCLI.twiki 9203699 > docs/src/site/twiki/FalconDocumentation.twiki 29d93f7 > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java > 78964dd > > prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java > 5b415a2 > prism/src/main/java/org/apache/falcon/resource/channel/HTTPChannel.java > 78f68ba > > prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java > ceabb06 > > prism/src/main/java/org/apache/falcon/security/FalconAuthenticationFilter.java > df64b44 > > prism/src/main/java/org/apache/falcon/security/FalconAuthorizationFilter.java > 15e94cd > prism/src/main/java/org/apache/falcon/security/HostnameFilter.java > PRE-CREATION > prism/src/main/webapp/WEB-INF/web.xml 551bf56 > prism/src/test/java/org/apache/falcon/resource/EntityManagerTest.java > cce8737 > > prism/src/test/java/org/apache/falcon/security/FalconAuthenticationFilterTest.java > 9e8c76a > prism/src/test/java/org/apache/falcon/security/HostnameFilterTest.java > PRE-CREATION > src/conf/startup.properties 9925373 > unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java eb65cb3 > unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 997b301 > webapp/pom.xml 5a9e1da > webapp/src/conf/oozie/conf/oozie-site.xml ded4873 > > webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java > 1f8cc1b > webapp/src/main/webapp/WEB-INF/distributed/web.xml 31d78a2 > webapp/src/main/webapp/WEB-INF/embedded/web.xml fa2db39 > webapp/src/main/webapp/WEB-INF/web.xml 2cfd7de > webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 0062070 > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java > f0cee61 > > webapp/src/test/java/org/apache/falcon/resource/MetadataResourceJerseyIT.java > eb1dda8 > webapp/src/test/java/org/apache/falcon/resource/TestContext.java 4a25b88 > webapp/src/test/resources/startup.properties PRE-CREATION > > Diff: https://reviews.apache.org/r/37771/diff/ > > > Testing > ------- > > Unit tests and IT tests. > > > Thanks, > > Sowmya Ramesh > >
