----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38096/#review97725 -----------------------------------------------------------
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 315) <https://reviews.apache.org/r/38096/#comment153734> We can just have one obtainEntityLocks method. The same can be used for both updates and submit. prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 321) <https://reviews.apache.org/r/38096/#comment153735> Add a Null check for entities that don't have dependents. prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 335) <https://reviews.apache.org/r/38096/#comment153736> As mentioned above, merge it with a single method. prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 347) <https://reviews.apache.org/r/38096/#comment153737> Rename this to "releaseEntityLocks" - Pallavi Rao On Sept. 3, 2015, 12:15 p.m., sandeep samudrala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38096/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2015, 12:15 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1410 > https://issues.apache.org/jira/browse/FALCON-1410 > > > Repository: falcon-git > > > Description > ------- > > Acquired lock on the entity that is getting submitted and failing any other > parallel submission upon lock already being acquired. > > > Diffs > ----- > > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java > 78964dd > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java > f0cee61 > > Diff: https://reviews.apache.org/r/38096/diff/ > > > Testing > ------- > > > Thanks, > > sandeep samudrala > >
