-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38166/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-348
https://issues.apache.org/jira/browse/FALCON-348
Repository: falcon-git
Description
-------
A shutdown hook is missing and services are shutdown in a brute force mode. I'd
like to see activemq, titan and such are shutdown gracefully so we don't lose
data and see ugly exceptions in the logs.
Diffs
-----
prism/src/main/java/org/apache/falcon/Main.java 96e003c
rerun/src/main/java/org/apache/falcon/rerun/handler/AbstractRerunConsumer.java
9ee94c5
rerun/src/main/java/org/apache/falcon/rerun/handler/AbstractRerunHandler.java
f019737
rerun/src/main/java/org/apache/falcon/rerun/handler/LateRerunHandler.java
c2cb09e
rerun/src/main/java/org/apache/falcon/rerun/handler/RetryHandler.java c6bc36f
rerun/src/main/java/org/apache/falcon/rerun/queue/ActiveMQueue.java 021e4cc
rerun/src/main/java/org/apache/falcon/rerun/service/LateRunService.java
2bb198b
Diff: https://reviews.apache.org/r/38166/diff/
Testing
-------
I have started and stopped the server. Logs look clean and each service gets
shutdown properly.
Handled activemq brokerservice and server stops separately.
Thanks,
sandeep samudrala