[
https://issues.apache.org/jira/browse/FALCON-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pallavi Rao reopened FALCON-1250:
---------------------------------
The patch caused a regression. See FALCON-1441.
"domain" is not an enumeration, so, validating against a domain will require
ensuring that we have only properties related to a single domain in a
.properties file. Domains that are used so far are falcon, prism, debug, it.
But, it is pretty much user-defined.
Also, currently, properties is designed in a such a way that domain specific
properties and properties that apply to all domains can co-exist. For example
prism.* and *.* can co-exist in a single file as it does in the current default
startup.properties. prism.* will take precedence when domain=prism. This makes
it difficult to validate for "a" domain.
[~bvellanki], your thoughts?
> Throw error when keys in startup.properties do not start with "*." or
> domain+"."
> --------------------------------------------------------------------------------
>
> Key: FALCON-1250
> URL: https://issues.apache.org/jira/browse/FALCON-1250
> Project: Falcon
> Issue Type: Improvement
> Reporter: Balu Vellanki
> Assignee: Narayan Periwal
> Fix For: trunk
>
> Attachments: FALCON-1250-v0.patch
>
>
> In org.apache.falcon.util.ApplicationProperties.java, method doLoadProperties
> only loads the keys that start with domain + "." or "*.". All other keys
> are ignored.
> If the keys do not start with domain + "." or "*.", it is probably because
> the user made a typo or mistake in the startup.properties. Instead of
> ignoring these keys, I propose that an error should be thrown.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
