[
https://issues.apache.org/jira/browse/FALCON-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14769029#comment-14769029
]
Balu Vellanki commented on FALCON-1442:
---------------------------------------
[~pallavi.rao] : I agree on the principle. There is a related discussion on
FALCON-1339, and the consensus is to show status as "Submitted, Running,
Completed, Suspended". I can work on this Jira and Falcon-1339 today and
provide you a fix. Will that work?
> Contract of WorkflowEngine API broken
> -------------------------------------
>
> Key: FALCON-1442
> URL: https://issues.apache.org/jira/browse/FALCON-1442
> Project: Falcon
> Issue Type: Bug
> Reporter: Pallavi Rao
>
> The bug is related to patch for FALCON-1371. Sorry to rake this up after the
> patch has been committed. I completely missed a problem when I reviewed the
> patch. My bad. The patch introduces 4-5 methods such as the one below:
> {code}
> public abstract boolean isActive(Map<String, BundleJob> bundles) throws
> FalconException;
> {code}
> This totally breaks the contract of the WorkflowEngine. The Workflow Engine
> API is not supposed to expose the internal details (whether the entity is
> submitted as bundle or not). The worflow engine API should accept only
> entities known to Falcon (such as cluster, entity, lifecycle).
> The new methods cause problem with the native scheduler (which extends
> AbsractWorkflowEngine) as the native scheduler does not work with bundles.
> I understand that the reason it was introduced was to optimize the number of
> calls, but, I would rather have the cleaner separation :-)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
