----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38294/#review99300 -----------------------------------------------------------
Ship it! Ship It! - Balu Vellanki On Sept. 16, 2015, 10:23 a.m., Pallavi Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38294/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2015, 10:23 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1434 > https://issues.apache.org/jira/browse/FALCON-1434 > > > Repository: falcon-git > > > Description > ------- > > The schedule API will be enhanced to accept a key-value properties. This is a > foundation to enable users to specify the scheduler on which they want to > schedule the entity. This in turn enables migration to native scheduler from > Oozie. > Example: > bin/falcon entity -schedule -props falcon.scheduler=native -name <entity name> > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java e684678 > client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java > 1146011 > client/src/main/java/org/apache/falcon/client/FalconClient.java 6075f5c > common/src/main/java/org/apache/falcon/entity/EntityUtil.java 2f05b1f > > common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java > ea86c2a > common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java f6a4679 > > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java > 5f79ca1 > > prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java > 61638f3 > > prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java > 23f1605 > unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java d907683 > unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java df73628 > unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 498f50e > > webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java > 3bafb25 > webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java b859256 > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java > 220e5a7 > webapp/src/test/java/org/apache/falcon/resource/TestContext.java f031137 > > Diff: https://reviews.apache.org/r/38294/diff/ > > > Testing > ------- > > UT added > Manually tested to ensure CLI accepts properties and it is propagated. > > > Thanks, > > Pallavi Rao > >
