----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38401/#review99302 -----------------------------------------------------------
Ship it! common/src/main/java/org/apache/falcon/entity/HiveUtil.java (line 41) <https://reviews.apache.org/r/38401/#comment156204> Minor nit: Use StringUtils.isBlank - Sowmya Ramesh On Sept. 16, 2015, 12:15 p.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38401/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2015, 12:15 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1460 > https://issues.apache.org/jira/browse/FALCON-1460 > > > Repository: falcon-git > > > Description > ------- > > Moved one method to ClusterHelper and added some unit tests. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java > 7f96827 > common/src/main/java/org/apache/falcon/entity/ClusterHelper.java 87b0fba > common/src/main/java/org/apache/falcon/entity/HiveUtil.java PRE-CREATION > > common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java > 5756f84 > common/src/main/java/org/apache/falcon/security/SecurityUtil.java 123a1a2 > common/src/test/java/org/apache/falcon/entity/HiveUtilTest.java > PRE-CREATION > oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java f9230da > > oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java > 671ae6b > > oozie/src/main/java/org/apache/falcon/oozie/feed/FeedReplicationWorkflowBuilder.java > 4dc55ff > > oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionWorkflowBuilder.java > b56f0dd > > oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java > 2f7787d > > oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java > d727ca3 > > Diff: https://reviews.apache.org/r/38401/diff/ > > > Testing > ------- > > Added a couple of unit tests. > > > Thanks, > > Ajay Yadava > >
