> On Sept. 17, 2015, 3:33 p.m., Scott Preece wrote: > >
Thanks Scott for reviewing the doc. I have incorporated your comments. > On Sept. 17, 2015, 3:33 p.m., Scott Preece wrote: > > docs/src/site/twiki/FalconEmailNotification.twiki, line 3 > > <https://reviews.apache.org/r/38448/diff/1/?file=1075835#file1075835line3> > > > > Recommend text change: > > Change "sending email based notification from Falcon when scheduled > > feed/process instance completed" > > > > To: > > "sending email notifications when scheduled feed/process instances > > complete." Done. > On Sept. 17, 2015, 3:33 p.m., Scott Preece wrote: > > docs/src/site/twiki/FalconEmailNotification.twiki, line 14 > > <https://reviews.apache.org/r/38448/diff/1/?file=1075835#file1075835line14> > > > > Recommend a text change: > > "specifies the address to send notifications to; multiple recipients > > may be provided as a comma-separated list" Done. > On Sept. 17, 2015, 3:33 p.m., Scott Preece wrote: > > docs/src/site/twiki/FalconEmailNotification.twiki, line 8 > > <https://reviews.apache.org/r/38448/diff/1/?file=1075835#file1075835line8> > > > > Will it confuse users that the "to" part looks like a literal e-mail > > address? Will people think that's the value they should use, rather than > > the intended recipient address? I have put more realistic email address to avoid confusion. - Peeyush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38448/#review99390 ----------------------------------------------------------- On Sept. 17, 2015, 7:07 a.m., Peeyush Bishnoi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38448/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2015, 7:07 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1426 > https://issues.apache.org/jira/browse/FALCON-1426 > > > Repository: falcon-git > > > Description > ------- > > FALCON-1426: Documentation for Falcon Email notification > > > Diffs > ----- > > docs/src/site/twiki/EntitySpecification.twiki bf45598 > docs/src/site/twiki/FalconDocumentation.twiki 68ed2e2 > docs/src/site/twiki/FalconEmailNotification.twiki PRE-CREATION > > Diff: https://reviews.apache.org/r/38448/diff/ > > > Testing > ------- > > Yes. > > > Thanks, > > Peeyush Bishnoi > >
