-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38465/#review99409
-----------------------------------------------------------
General comments: Can you please add a section in the docs for this
explaining the various types of import options and the implications.
How does one create a Datasource entity using the REST api?
Please create a tracking bug for UI enhancments?
client/src/main/resources/datasource-0.1.xsd (line 19)
<https://reviews.apache.org/r/38465/#comment156302>
nit: trailing whitespace
client/src/main/resources/datasource-0.1.xsd (line 55)
<https://reviews.apache.org/r/38465/#comment156303>
nit: whitespace
client/src/main/resources/datasource-0.1.xsd (line 78)
<https://reviews.apache.org/r/38465/#comment156305>
Nit: Trailing whitespace
client/src/main/resources/feed-0.1.xsd (line 409)
<https://reviews.apache.org/r/38465/#comment156635>
Please remove trailing blanks in all the files
- Venkat Ranganathan
On Sept. 18, 2015, 5:26 p.m., Venkatesan Ramachandran wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38465/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 5:26 p.m.)
>
>
> Review request for Falcon, Ajay Yadava, Balu Vellanki, Peeyush Bishnoi,
> Sowmya Ramesh, and Venkat Ranganathan.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1459 : Ability to import from database
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/LifeCycle.java 58a2a6c
> client/src/main/java/org/apache/falcon/Tag.java beeb812
> client/src/main/java/org/apache/falcon/entity/v0/EntityType.java 0657124
> client/src/main/java/org/apache/falcon/metadata/RelationshipType.java
> f034772
> client/src/main/resources/feed-0.1.xsd 4ff8baa
> client/src/main/resources/jaxb-binding.xjb f644f40
> common/src/main/java/org/apache/falcon/entity/EntityUtil.java 2f05b1f
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 572923b
>
> common/src/main/java/org/apache/falcon/entity/parser/EntityParserFactory.java
> 5a33201
> common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java
> 992fc51
> common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java
> e27187b
> common/src/main/java/org/apache/falcon/entity/v0/EntityGraph.java bd4c6cf
>
> common/src/main/java/org/apache/falcon/entity/v0/EntityIntegrityChecker.java
> bd32852
>
> common/src/main/java/org/apache/falcon/metadata/EntityRelationshipGraphBuilder.java
> 8c3876c
>
> common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java
> 4454239
> common/src/test/java/org/apache/falcon/entity/AbstractTestBase.java 6179855
> common/src/test/java/org/apache/falcon/entity/EntityTypeTest.java 640e87d
> common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java c70cfcc
>
> common/src/test/java/org/apache/falcon/entity/parser/FeedEntityParserTest.java
> d203b7c
> common/src/test/java/org/apache/falcon/entity/v0/EntityGraphTest.java
> 3863b11
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HiveAssert.java
> 2a934b5
> oozie/src/main/java/org/apache/falcon/oozie/OozieCoordinatorBuilder.java
> 85f5330
>
> oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java
> 3213a70
> oozie/src/main/java/org/apache/falcon/oozie/feed/FeedBundleBuilder.java
> b819dee
> pom.xml 646de69
> webapp/pom.xml 828f7f5
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java f031137
>
> Diff: https://reviews.apache.org/r/38465/diff/
>
>
> Testing
> -------
>
> * Unit tests
> * Integration tests
> * Manual tests
> * Setup MySQL, create table and populate
> * Create datasource and feed entity with import policy in Falcon
> * Made sure the data lands up in the HDFS.
>
>
> Thanks,
>
> Venkatesan Ramachandran
>
>
