> On Sept. 18, 2015, 6:44 p.m., Sowmya Ramesh wrote: > >
Thanks Sowmya for providing the comments. > On Sept. 18, 2015, 6:44 p.m., Sowmya Ramesh wrote: > > client/src/main/java/org/apache/falcon/recipe/RecipeToolOptions.java, line > > 47 > > <https://reviews.apache.org/r/38350/diff/1/?file=1072382#file1072382line47> > > > > Minor nit: Can you preserve the format and use > > falcon.recipe.notification.receivers? - this is teh format used for all > > other recipe options Done. > On Sept. 18, 2015, 6:44 p.m., Sowmya Ramesh wrote: > > client/src/main/java/org/apache/falcon/recipe/util/RecipeProcessBuilderUtils.java, > > line 182 > > <https://reviews.apache.org/r/38350/diff/1/?file=1072383#file1072383line182> > > > > what happens if email addresses is not passed/empty? will it break > > anything? If email address is not passed or if it is empty, we have already assumed earlier that by default it will be "NA". For more safety purpose, I have assigned to "NA" in the class itself if it is empty. > On Sept. 18, 2015, 6:44 p.m., Sowmya Ramesh wrote: > > client/src/main/java/org/apache/falcon/recipe/util/RecipeProcessBuilderUtils.java, > > line 184 > > <https://reviews.apache.org/r/38350/diff/1/?file=1072383#file1072383line184> > > > > Minor nit: Use !isBlank Done. I have used isNotEmpty to align with other functions in the class as they also use isNotEmpty. I have put a check with isNotBlank now. > On Sept. 18, 2015, 6:44 p.m., Sowmya Ramesh wrote: > > addons/recipes/hdfs-replication/src/main/resources/hdfs-replication.properties, > > line 78 > > <https://reviews.apache.org/r/38350/diff/1/?file=1072375#file1072375line78> > > > > Minor nit: Can you preserve the format and use > > falcon.recipe.notification.receivers? - this is teh format used for all > > other recipe options Done. > On Sept. 18, 2015, 6:44 p.m., Sowmya Ramesh wrote: > > addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery.properties, > > line 95 > > <https://reviews.apache.org/r/38350/diff/1/?file=1072381#file1072381line95> > > > > same as above Done. - Peeyush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38350/#review99580 ----------------------------------------------------------- On Sept. 14, 2015, 10:57 a.m., Peeyush Bishnoi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38350/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2015, 10:57 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1437 > https://issues.apache.org/jira/browse/FALCON-1437 > > > Repository: falcon-git > > > Description > ------- > > Presently DR recipes uses Oozie email action for notification, it must be > updated to use Falcon notification. > > > Diffs > ----- > > > addons/recipes/hdfs-replication/src/main/resources/hdfs-replication-template.xml > de0f748 > > addons/recipes/hdfs-replication/src/main/resources/hdfs-replication-workflow.xml > e35773f > > addons/recipes/hdfs-replication/src/main/resources/hdfs-replication.properties > 64ab6b8 > > addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure-template.xml > 3afbef0 > > addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure-workflow.xml > 7362c2e > > addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure.properties > b2d670a > > addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-template.xml > 3afbef0 > > addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-workflow.xml > c441998 > > addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery.properties > 42ae30b > client/src/main/java/org/apache/falcon/recipe/RecipeToolOptions.java > 5df9b0a > > client/src/main/java/org/apache/falcon/recipe/util/RecipeProcessBuilderUtils.java > 9522816 > webapp/src/test/resources/hdfs-replication-template.xml b93cc0b > webapp/src/test/resources/hdfs-replication.properties 1b485b4 > > Diff: https://reviews.apache.org/r/38350/diff/ > > > Testing > ------- > > Yes. This patch need to applied after patch from FALCON-1425 has been applied. > > > Thanks, > > Peeyush Bishnoi > >
