> On Sept. 25, 2015, 5:43 a.m., Peeyush Bishnoi wrote: > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java, line 253 > > <https://reviews.apache.org/r/38710/diff/1/?file=1083841#file1083841line253> > > > > Instead of Exception ex, can we use NumberFormatException, as parseInt > > throws NumberFormatException. See if it is possible. > > Narayan Periwal wrote: > Making debug from String to boolean as suggested by boolean, so now we > can continue with Exception ex > > Narayan Periwal wrote: > Actually, now there is no need for the try-catch block > > Peeyush Bishnoi wrote: > If setting debug mode to boolean , it means debug is required or not. In > this scenario, upto what level of debug logs will be shown as there are > multiple levels like WARN,DEBUG,ERROR,INFO etc. Can you just scope it and add > documentation as well for user convenience.
As of now, we just show the Web Services API details used by any commands. We are not showing the server side logs. - Narayan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38710/#review100533 ----------------------------------------------------------- On Sept. 25, 2015, 9:23 a.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38710/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2015, 9:23 a.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > With this feature, users can specify "-debug" in CLI arguments to get the > debug statements in Stdout. > eg. falcon entity -type feed -name in-feed.xml -submit -debug > Also, users can export the env variable FALCON_DEBUG to a non-zero value to > get the debug statements on stdout. > Starting right now with getting basic debug output such as the Http > connection URL to the server, this can be later extended for printing more > debug statements at various stages. > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649 > client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b > docs/src/site/twiki/FalconCLI.twiki 4f72bf8 > > Diff: https://reviews.apache.org/r/38710/diff/ > > > Testing > ------- > > Done > > > Thanks, > > Narayan Periwal > >
