> On Sept. 25, 2015, 8:15 a.m., Srikanth Sundarrajan wrote: > > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java, > > line 199 > > <https://reviews.apache.org/r/38707/diff/2/?file=1084263#file1084263line199> > > > > If there is an error in initializeService, the falcon server wouldn't > > startup anyway. So why handle IOException on deserialize differently. Would > > it be cleaner to just abort startup if deserialize fails. If admin wants to > > start with clean state, they can delete the state data and re-start.
initializeService won't throw errors, it's just creating new objects of set, date etc. IOException is for checking if the file exists. However, deserialize does have the behavior you have mentioned and swallows the exception and does a clean state restart. Aborting startup is definitely the better option than silently doing a restart. I will make the necessary changes. - Ajay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38707/#review100562 ----------------------------------------------------------- On Sept. 24, 2015, 8:54 p.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38707/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2015, 8:54 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1472 > https://issues.apache.org/jira/browse/FALCON-1472 > > > Repository: falcon-git > > > Description > ------- > > Apart from the current issue, this patch also addresses the following issues: > 1) FALCON-1474 > 2) FALCON-1475 > It also adds one more enhancement to DeploymentUtil where colo should be > ignored in embedded mode. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/util/DeploymentUtil.java 5d65073 > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java > 37aa9e6 > src/conf/log4j.xml 1341c6e > > Diff: https://reviews.apache.org/r/38707/diff/ > > > Testing > ------- > > Logging and Deployment issues. Verified manually. > > > Thanks, > > Ajay Yadava > >
