----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38794/#review100807 -----------------------------------------------------------
client/src/main/java/org/apache/falcon/cli/FalconCLI.java (line 473) <https://reviews.apache.org/r/38794/#comment158047> slaMiss for a method name is a bit misleading client/src/main/java/org/apache/falcon/cli/FalconCLI.java (line 723) <https://reviews.apache.org/r/38794/#comment158048> Is this only sla miss for feed ? Also for a process. From the result it seems to cover all schedulable entities. client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstanceResult.java (line 33) <https://reviews.apache.org/r/38794/#comment158049> Should this be extending InstanceResult instead ? Will InstanceResult not suffice in this case ? prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java (line 160) <https://reviews.apache.org/r/38794/#comment158051> Shouldn't be accessing the FeedSLAMonitoringService instance via ServiceRegistry instead of adding a static method to the class ? prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java (line 115) <https://reviews.apache.org/r/38794/#comment158050> Should the path be sla-status instead ? prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java (line 453) <https://reviews.apache.org/r/38794/#comment158052> Am assuming over time when an instance becomes available it would be removed from missingInstances. In this case would SLA-Miss return nothing even though the data arrived quite late ? In other words, will this feature only report missing SLA while the feed is unavailable, or will it also be able to report misses even after the data became available. - Srikanth Sundarrajan On Sept. 27, 2015, 11:25 p.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38794/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2015, 11:25 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1473 > https://issues.apache.org/jira/browse/FALCON-1473 > > > Repository: falcon-git > > > Description > ------- > > This api lists all the pending feed instances in a given time range which > have missed sla. > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/ResponseHelper.java a13682b > client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649 > client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b > client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 62b810c > > client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstance.java > f5be63d > > client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstanceResult.java > PRE-CREATION > common/src/main/java/org/apache/falcon/entity/FeedHelper.java 572923b > common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java > 4f5599e > common/src/main/resources/startup.properties 9db460c > docs/src/site/twiki/FalconCLI.twiki 4f72bf8 > docs/src/site/twiki/restapi/FeedSLA.twiki PRE-CREATION > docs/src/site/twiki/restapi/ResourceList.twiki ea3e3b6 > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java > 2682257 > > prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java > 3280789 > > prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java > 47038e5 > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java > 8bf43b8 > prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java > PRE-CREATION > src/conf/startup.properties 8f3bc35 > > webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java > 1c0fc74 > > Diff: https://reviews.apache.org/r/38794/diff/ > > > Testing > ------- > > Unit tests added. > Tested manually by deploying. > > > Thanks, > > Ajay Yadava > >
