> On Oct. 1, 2015, 8:52 a.m., Srikanth Sundarrajan wrote: > > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java, > > line 298 > > <https://reviews.apache.org/r/38852/diff/1/?file=1086951#file1086951line298> > > > > Dont see this variable being defined. Am I missing a patch in between ?
Line 285 & 289. - Ajay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38852/#review101201 ----------------------------------------------------------- On Oct. 1, 2015, 7:02 a.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38852/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2015, 7:02 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1476 > https://issues.apache.org/jira/browse/FALCON-1476 > > > Repository: falcon-git > > > Description > ------- > > Currently SLA Monitoring service keeps on logging indefinitely for a given > entity until it gets data for that entity. In case user gives wrong data > path, monitoring service will look for the entity infinitely as data path > will never be there for it. It is better to introduce a threshold which user > can use to define how long he wants the service to run (with a default value > set to a long interval). > > > Diffs > ----- > > common/src/main/resources/startup.properties 3383129 > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java > 193aa64 > prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java > bc03cb5 > src/conf/startup.properties 8e4ce97 > > Diff: https://reviews.apache.org/r/38852/diff/ > > > Testing > ------- > > > Thanks, > > Ajay Yadava > >
