----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39062/#review101687 -----------------------------------------------------------
Ship it! Good work Sowmya. +1 - Venkat Ranganathan On Oct. 6, 2015, 2:07 p.m., Sowmya Ramesh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39062/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2015, 2:07 p.m.) > > > Review request for Falcon, Ajay Yadava and Venkat Ranganathan. > > > Bugs: FALCON-1466 > https://issues.apache.org/jira/browse/FALCON-1466 > > > Repository: falcon-git > > > Description > ------- > > Root cause: Proxy user UT"s in the test set up configure the proxy user group > and host in RuntimeProperties. In RuntimeProperties if INSTANCE is null then > it is initialized , also it spins a thread to dynamically load it. If when > the tests run INSTANCE is null then there ia a race condition where after > proxy user config is set it can be overwritten by the thread that is spun in > DynamicLoader.run(). Thread is spun just after iniitng INSTANCE and hence > INSTANCE need not have to be updated when the thread starts running. To > remove the flakiness moved Thread.sleep to beginning of DynamicLoader.run(). > > Running org.apache.falcon.security.CurrentUserTest > Tests run: 46, Failures: 1, Errors: 0, Skipped: 45, Time elapsed: 1.635 sec > <<< FAILURE! - in org.apache.falcon.security.CurrentUserTest > setUp(org.apache.falcon.security.CurrentUserTest) Time elapsed: 1.266 sec > <<< FAILURE! > org.apache.falcon.FalconException: > falcon.service.ProxyUserService.proxyuser.falcon.service.ProxyUserService.proxyuser.foo.groups > property not set in runtime properties. Please add it. > at > org.apache.falcon.service.ProxyUserService.init(ProxyUserService.java:97) > at > org.apache.falcon.security.CurrentUserTest.setUp(CurrentUserTest.java:51) > > > Running org.apache.falcon.service.ProxyUserServiceTest > Tests run: 13, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.775 sec > <<< FAILURE! - in org.apache.falcon.service.ProxyUserServiceTest > testInvalidGroup(org.apache.falcon.service.ProxyUserServiceTest) Time > elapsed: 0.027 sec <<< FAILURE! > org.testng.TestException: > Expected exception java.security.AccessControlException but got > org.apache.falcon.FalconException: > falcon.service.ProxyUserService.proxyuser.falcon.service.ProxyUserService.proxyuser.foo.groups > property not set in runtime properties. Please add it. > at org.apache.falcon.service.ProxyUserService.init(ProxyUserService.java:97) > at > org.apache.falcon.service.ProxyUserServiceTest.testInvalidGroup(ProxyUserServiceTest.java:149) > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/service/ProxyUserService.java > 0ad6663 > common/src/main/java/org/apache/falcon/util/RuntimeProperties.java 3ff30ee > > Diff: https://reviews.apache.org/r/39062/diff/ > > > Testing > ------- > > Existing UT's pass > > > Thanks, > > Sowmya Ramesh > >
