----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39115/#review101868 -----------------------------------------------------------
unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java (line 133) <https://reviews.apache.org/r/39115/#comment159370> With this new method, shouldn't we merge the older getInstanceStatus method with this and use that through out, rather than having 2 similar methods? - Pallavi Rao On Oct. 8, 2015, 5:01 a.m., pavan kumar kolamuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39115/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2015, 5:01 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1516 > https://issues.apache.org/jira/browse/FALCON-1516 > > > Repository: falcon-git > > > Description > ------- > > As of now Falcon Unit only supports Process execution , Adding support for > Retention support for Falcon Unit useful to simplify integration tests in > future. > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java > 265e08c > common/src/main/java/org/apache/falcon/util/DateUtil.java f89ef64 > prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java > c1b4da6 > unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 169614b > unit/src/main/java/org/apache/falcon/unit/LocalInstanceManager.java > PRE-CREATION > > unit/src/main/java/org/apache/falcon/unit/LocalSchedulableEntityManager.java > PRE-CREATION > unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 995af2b > unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java fa9c664 > unit/src/test/resources/infeed.xml 509d868 > > Diff: https://reviews.apache.org/r/39115/diff/ > > > Testing > ------- > > Added Unit Tests > > > Thanks, > > pavan kumar kolamuri > >
