----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33443/#review101973 -----------------------------------------------------------
common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java (line 427) <https://reviews.apache.org/r/33443/#comment159482> Would it make sense to check if counters are enabled for this workflow and then check for existence of counter file? Since by default counters are not enabled for WF, LOG.error() will be printed in the log - Venkatesan Ramachandran On Oct. 7, 2015, 9:17 a.m., Peeyush Bishnoi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33443/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 9:17 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1102 > https://issues.apache.org/jira/browse/FALCON-1102 > > > Repository: falcon-git > > > Description > ------- > > FALCON-1102: Gather data transfer detail of replication job submitted from > HDFS recipe > > > Diffs > ----- > > > addons/recipes/hdfs-replication/src/main/resources/hdfs-replication-workflow.xml > 942421f > > common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java > 016c622 > common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionArgs.java > 9456fb9 > > common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java > 4454239 > > common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java > 89e8178 > metrics/pom.xml a0358db > metrics/src/main/java/org/apache/falcon/job/FSReplicationCounters.java > PRE-CREATION > metrics/src/main/java/org/apache/falcon/job/JobCounters.java PRE-CREATION > metrics/src/main/java/org/apache/falcon/job/JobCountersHandler.java > PRE-CREATION > metrics/src/main/java/org/apache/falcon/job/JobType.java PRE-CREATION > metrics/src/main/java/org/apache/falcon/job/ReplicationJobCountersList.java > PRE-CREATION > metrics/src/test/java/org/apache/falcon/job/FSReplicationCountersTest.java > PRE-CREATION > > oozie/src/main/java/org/apache/falcon/oozie/feed/FSReplicationWorkflowBuilder.java > b82f4e0 > > oozie/src/main/java/org/apache/falcon/oozie/feed/FeedReplicationWorkflowBuilder.java > a7c19cd > > oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java > cfce1ae > oozie/src/test/resources/feed/fs-replication-feed-counters.xml PRE-CREATION > replication/pom.xml 3cc96fc > replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java > a226058 > > Diff: https://reviews.apache.org/r/33443/diff/ > > > Testing > ------- > > Yes. Unit test cases added. > > > Thanks, > > Peeyush Bishnoi > >
