----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39229/#review102244 -----------------------------------------------------------
oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java (line 66) <https://reviews.apache.org/r/39229/#comment159814> Please add comments on what is B,C and W for better readability unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java (line 212) <https://reviews.apache.org/r/39229/#comment159815> formatting. remove extra empty line. unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 94) <https://reviews.apache.org/r/39229/#comment159818> The process scheduled will be running for each minute and so might take resources for scheduling. Is the deletion of the processes scheduled happening? Entried from config store are getting deleted, but entries from oozie are only happening at the end of the all the tests. Can you tear down it from oozie too as soon as the individual test method finishes or else delete them at the end of the method. unit/src/test/resources/process1.xml (line 23) <https://reviews.apache.org/r/39229/#comment159820> Can you reduce the time interval between start and and end?. I know as of now its getting cleaned up immediately after the test, its good to keep it running for less time and also helps any use case to use it later and not cause any issue. - sandeep samudrala On Oct. 12, 2015, 12:07 p.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39229/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2015, 12:07 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1519 > https://issues.apache.org/jira/browse/FALCON-1519 > > > Repository: falcon-git > > > Description > ------- > > Suspend and Resume Functionalities should be supported in Falcon unit. > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java > 2358289 > oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java > 217cec9 > unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 3ce261e > > unit/src/main/java/org/apache/falcon/unit/LocalSchedulableEntityManager.java > d793cf2 > unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 45b88f0 > unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java d2e574b > unit/src/test/resources/process1.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/39229/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > Narayan Periwal > >
