-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39242/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-1524
    https://issues.apache.org/jira/browse/FALCON-1524


Repository: falcon-git


Description
-------

2 enhancements:
1. Check that retention should not be more frequent than the data availability.
2. Oozie doesn't behave appropriately for retention for high frequencies like 
minutes(3) etc. Retention follows LAST_ONLY execution order and for high 
frequencies and default configuration retention might not execute. To make it 
work you will need to override 
oozie.service.CoordMaterializeTriggerService.materialization.window
and
oozie.service.CoordMaterializeTriggerService.lookup.interval
which might affect the Oozie system performance.
Hence we should set a limit like hours(1) for retention frequency and retention 
more frequent than that should throw validation error.
Originally reported by Pragya Mittal


Diffs
-----

  common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java 
6be2495 
  
common/src/main/java/org/apache/falcon/lifecycle/retention/AgeBasedDelete.java 
a4ae780 
  common/src/main/java/org/apache/falcon/util/DateUtil.java f89ef64 
  
common/src/test/java/org/apache/falcon/entity/parser/FeedEntityParserTest.java 
1c43800 

Diff: https://reviews.apache.org/r/39242/diff/


Testing
-------

Added Unit tests for all the scenarios.


Thanks,

Ajay Yadava

Reply via email to