----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38882/#review101875 -----------------------------------------------------------
client/src/main/java/org/apache/falcon/cli/FalconInstanceCLI.java (line 48) <https://reviews.apache.org/r/38882/#comment159375> Why public ? client/src/main/java/org/apache/falcon/cli/FalconInstanceCLI.java (line 154) <https://reviews.apache.org/r/38882/#comment159376> Can you change the description and say something like all attempts for job ? oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java (line 825) <https://reviews.apache.org/r/38882/#comment160188> Can you use props and fit this logic in performAction method only ? Is this method really required ? oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java (line 849) <https://reviews.apache.org/r/38882/#comment160117> You can use getWorkflowInfo here oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java (line 859) <https://reviews.apache.org/r/38882/#comment160118> Won't instanceList contain duplicate entries? Initially one workflow got added and later all workflow's added . - pavan kumar kolamuri On Oct. 6, 2015, 1:22 p.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38882/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2015, 1:22 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1495 > https://issues.apache.org/jira/browse/FALCON-1495 > > > Repository: falcon-git > > > Description > ------- > > Most of the times , when there are failures in the pipelines, retries run and > the workflows might have got succeeded in sub sequential retry. But for end > user to figure out why it has failed initially might be useful to understand > for failures handling and SLA misses. > > As of now to figure out the same, its a tedious task to get such information > by either going through oozie DB/logs or via the logs backed up in hdfs by > the falcon postprocessing(which is 100% reliable as in few cases, falcon post > processing might fail or for some reason if it couldn't back up the logs). > > In either case, Falcon should abstract the oozie client layer to be used by > end user, and support all runs status to end user. > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/cli/FalconInstanceCLI.java 24be7f1 > client/src/main/java/org/apache/falcon/client/FalconClient.java 20f6447 > > common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java > 0b560bb > docs/src/site/twiki/FalconCLI.twiki 22003d3 > docs/src/site/twiki/restapi/InstanceList.twiki 229d6f9 > > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java > 6660af1 > prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java > c1b4da6 > > prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java > 63e0647 > > prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java > 96c99f0 > unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 169614b > webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java > 76c66f3 > > Diff: https://reviews.apache.org/r/38882/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > Narayan Periwal > >
