> On Oct. 14, 2015, 12:26 a.m., Sowmya Ramesh wrote: > >
Thanks for the review. > On Oct. 14, 2015, 12:26 a.m., Sowmya Ramesh wrote: > > addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRTool.java, line 114 > > <https://reviews.apache.org/r/39261/diff/1/?file=1097136#file1097136line114> > > > > is logDir fully qualified path which has the FS endpoint? If so there > > will not be issues accessing it from any cluster. > > > > Lets say if file is generated on different cluster how is it handled > > for secure setup? In HadoopClientFactory.createFalconFileSystem if secure > > setup it sets "dfs.namenode.kerberos.principal" - isn't that required ? Yes, logDir is fully qualified as mentioned in my earlier comment. - Peeyush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39261/#review102563 ----------------------------------------------------------- On Oct. 13, 2015, 8:58 a.m., Peeyush Bishnoi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39261/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 8:58 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1480 > https://issues.apache.org/jira/browse/FALCON-1480 > > > Repository: falcon-git > > > Description > ------- > > FALCON-1480: Gather data transfer details of Hive DR > > > Diffs > ----- > > addons/hivedr/pom.xml a1be288 > addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRArgs.java 574524d > addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRTool.java bebdb0b > > addons/hivedr/src/main/java/org/apache/falcon/hive/mapreduce/CopyMapper.java > 5eb8acb > addons/hivedr/src/main/java/org/apache/falcon/hive/util/EventUtils.java > f8397ff > addons/hivedr/src/main/java/org/apache/falcon/hive/util/HiveDRUtils.java > d9d6ab0 > > addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure-workflow.xml > 74902b4 > > addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-workflow.xml > 72d40a3 > metrics/src/main/java/org/apache/falcon/job/HiveReplicationCounters.java > PRE-CREATION > metrics/src/main/java/org/apache/falcon/job/JobCountersHandler.java e8b68ff > metrics/src/main/java/org/apache/falcon/job/JobType.java 456e57f > > Diff: https://reviews.apache.org/r/39261/diff/ > > > Testing > ------- > > Yes. Manual testing done. > > > Thanks, > > Peeyush Bishnoi > >
