-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39336/
-----------------------------------------------------------
(Updated Oct. 19, 2015, 9:07 a.m.)
Review request for Falcon.
Changes
-------
Addressed review comments
Bugs: FALCON-1541
https://issues.apache.org/jira/browse/FALCON-1541
Repository: falcon-git
Description
-------
Currently falcon is packaged in a way that deploy.properties are not a part of
bundle. So when we deploy falcon in distributed mode, falcon has no way of
knowing which mode it is in,thus considering embedded mode which is default by
nature. This was discovered while testing FALCON-1515 and FALCON-1526. IMO
falcon should bundle deploy.properties while packaging and handle the
configurations depending on the mode of deployment.
Diffs (updated)
-----
webapp/pom.xml e63aa44
webapp/src/main/resources/deploy.properties e6ff02e
webapp/src/main/webapp/WEB-INF/distributed/deploy.properties PRE-CREATION
webapp/src/main/webapp/WEB-INF/embedded/deploy.properties PRE-CREATION
Diff: https://reviews.apache.org/r/39336/diff/
Testing
-------
Deployed locally in distributed as well as embedded mode.
Thanks,
PRAGYA MITTAL