> On Oct. 19, 2015, 4:51 a.m., Ajay Yadava wrote: > > scheduler/src/main/java/org/apache/falcon/state/store/StateStore.java, line > > 46 > > <https://reviews.apache.org/r/35724/diff/3/?file=1097315#file1097315line46> > > > > Passing string is error prone, can we change it to accept an object > > which represents EntityKey/InstanceKey? This will result in stronger > > contract.
Makes sense. Addressed it. > On Oct. 19, 2015, 4:51 a.m., Ajay Yadava wrote: > > scheduler/src/main/java/org/apache/falcon/execution/EntityExecutor.java, > > line 99 > > <https://reviews.apache.org/r/35724/diff/3/?file=1097282#file1097282line99> > > > > Entity and instance level operations are all in one class. Can we > > please separate entity level operations and instance level operations in > > different classes? Will be addressed in FALCON-1548 > On Oct. 19, 2015, 4:51 a.m., Ajay Yadava wrote: > > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java, > > line 224 > > <https://reviews.apache.org/r/35724/diff/3/?file=1097287#file1097287line224> > > > > Can we separate out the entity and instance level operations? Will be addressed in FALCON-1548 > On Oct. 19, 2015, 4:51 a.m., Ajay Yadava wrote: > > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java, > > line 236 > > <https://reviews.apache.org/r/35724/diff/3/?file=1097287#file1097287line236> > > > > We should avoid typecasting and should leverage compile time checks as > > much as possible. In general, yes. But, in this case, since the method signature has ExecutionInstance as it should, it is difficult to avoid this. > On Oct. 19, 2015, 4:51 a.m., Ajay Yadava wrote: > > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutionInstance.java, > > line 269 > > <https://reviews.apache.org/r/35724/diff/3/?file=1097286#file1097286line269> > > > > Please create JIRA and remove TODO. FALCON-1549. Still want to keep the TODO in code for easy reference. > On Oct. 19, 2015, 4:51 a.m., Ajay Yadava wrote: > > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java, > > line 174 > > <https://reviews.apache.org/r/35724/diff/3/?file=1097287#file1097287line174> > > > > Please create JIRA and remove TODO. FALCON-1549. Still want to keep the TODO in code for easy reference. > On Oct. 19, 2015, 4:51 a.m., Ajay Yadava wrote: > > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java, > > line 174 > > <https://reviews.apache.org/r/35724/diff/3/?file=1097287#file1097287line174> > > > > Please remove TODO and create JIRA. FALCON-1549. Still want to keep the TODO in code for easy reference. > On Oct. 19, 2015, 4:51 a.m., Ajay Yadava wrote: > > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java, > > line 312 > > <https://reviews.apache.org/r/35724/diff/3/?file=1097287#file1097287line312> > > > > Please create JIRA and remove TODO. FALCON-1549. Still want to keep the TODO in code for easy reference. > On Oct. 19, 2015, 4:51 a.m., Ajay Yadava wrote: > > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java, > > line 379 > > <https://reviews.apache.org/r/35724/diff/3/?file=1097287#file1097287line379> > > > > Please create JIRA and remove todos. FALCON-1549. Still want to keep the TODO in code for easy reference. > On Oct. 19, 2015, 4:51 a.m., Ajay Yadava wrote: > > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java, > > line 380 > > <https://reviews.apache.org/r/35724/diff/3/?file=1097287#file1097287line380> > > > > Please create JIRA and remove TODO. FALCON-1549. Still want to keep the TODO in code for easy reference. - Pallavi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35724/#review102859 ----------------------------------------------------------- On Oct. 13, 2015, 11:53 a.m., Pallavi Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35724/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 11:53 a.m.) > > > Review request for Falcon and Srikanth Sundarrajan. > > > Bugs: FALCON-1213 > https://issues.apache.org/jira/browse/FALCON-1213 > > > Repository: falcon-git > > > Description > ------- > > The patch has the basic framework for the scheduler. Each of the individual > service needs to be implemented completely and will be done as separate > JIRAs. The intention of the patch is ensure the base framework satisfies all > use cases and get any early feedback in terms of course correction. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/EntityUtil.java 3ab9339 > pom.xml 54e6cd1 > scheduler/pom.xml PRE-CREATION > scheduler/src/main/java/org/apache/falcon/exception/DAGEngineException.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/exception/InvalidStateTransitionException.java > PRE-CREATION > scheduler/src/main/java/org/apache/falcon/exception/ServiceException.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/exception/StateStoreException.java > PRE-CREATION > scheduler/src/main/java/org/apache/falcon/execution/EntityExecutor.java > PRE-CREATION > scheduler/src/main/java/org/apache/falcon/execution/ExecutionInstance.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/execution/FalconExecutionService.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/execution/NotificationHandler.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutionInstance.java > PRE-CREATION > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java > PRE-CREATION > scheduler/src/main/java/org/apache/falcon/execution/SchedulerUtil.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/notification/service/FalconNotificationService.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/notification/service/NotificationServicesRegistry.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/notification/service/event/DataEvent.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/notification/service/event/Event.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/notification/service/event/JobCompletedEvent.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/notification/service/event/JobScheduledEvent.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/notification/service/event/TimeElapsedEvent.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/notification/service/impl/AlarmService.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/notification/service/impl/DataAvailabilityService.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/notification/service/request/AlarmRequest.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/notification/service/request/DataNotificationRequest.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/notification/service/request/JobCompletionNotificationRequest.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/notification/service/request/JobScheduleNotificationRequest.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/notification/service/request/NotificationRequest.java > PRE-CREATION > scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java > PRE-CREATION > scheduler/src/main/java/org/apache/falcon/state/EntityState.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/state/EntityStateChangeHandler.java > PRE-CREATION > scheduler/src/main/java/org/apache/falcon/state/ID.java PRE-CREATION > scheduler/src/main/java/org/apache/falcon/state/InstanceState.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/state/InstanceStateChangeHandler.java > PRE-CREATION > scheduler/src/main/java/org/apache/falcon/state/StateMachine.java > PRE-CREATION > scheduler/src/main/java/org/apache/falcon/state/StateService.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/state/store/AbstractStateStore.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/state/store/InMemoryStateStore.java > PRE-CREATION > scheduler/src/main/java/org/apache/falcon/state/store/StateStore.java > PRE-CREATION > scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngineFactory.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java > PRE-CREATION > > scheduler/src/test/java/org/apache/falcon/execution/FalconExecutionServiceTest.java > PRE-CREATION > scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java > PRE-CREATION > scheduler/src/test/java/org/apache/falcon/execution/SchedulerUtilTest.java > PRE-CREATION > > scheduler/src/test/java/org/apache/falcon/notification/service/AlarmServiceTest.java > PRE-CREATION > > scheduler/src/test/java/org/apache/falcon/notification/service/SchedulerServiceTest.java > PRE-CREATION > scheduler/src/test/java/org/apache/falcon/predicate/PredicateTest.java > PRE-CREATION > scheduler/src/test/java/org/apache/falcon/state/EntityStateServiceTest.java > PRE-CREATION > > scheduler/src/test/java/org/apache/falcon/state/InstanceStateServiceTest.java > PRE-CREATION > scheduler/src/test/resources/config/cluster/cluster-0.1.xml PRE-CREATION > scheduler/src/test/resources/config/feed/feed-0.1.xml PRE-CREATION > scheduler/src/test/resources/config/process/process-0.1.xml PRE-CREATION > webapp/pom.xml e63aa44 > > Diff: https://reviews.apache.org/r/35724/diff/ > > > Testing > ------- > > New UTs have been added. > > > Thanks, > > Pallavi Rao > >
