----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39391/#review103123 -----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java (line 560) <https://reviews.apache.org/r/39391/#comment161066> instanceTime can be renamed to params which will give more readability. falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java (line 502) <https://reviews.apache.org/r/39391/#comment161068> Instead of making it as a private function, consider it adding it to OozieUtil so that future test case can use the same method. I have encountered cases where this function would be helpful. falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceDependencyTest.java (line 68) <https://reviews.apache.org/r/39391/#comment161069> Please rename the class to PipelineInstanceDependencyTestand add it under 'triage' package. falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceDependencyTest.java (line 331) <https://reviews.apache.org/r/39391/#comment161070> This can be added as a public method in EntityLineageUtil.java - PRAGYA MITTAL On Oct. 19, 2015, 12:27 p.m., Paul Isaychuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39391/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 12:27 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1546 > https://issues.apache.org/jira/browse/FALCON-1546 > > > Repository: falcon-git > > > Description > ------- > > Set of new tests and test fixes > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java > b905bee > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java > 83d06a2 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java > 10463c2 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/KerberosHelper.java > 9d028fa > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java > 83547e7 > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java > d956549 > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java > 0fbfc38 > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/EntityWizardPage.java > PRE-CREATION > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/FeedWizardPage.java > f3a107c > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/LoginPage.java > 3193d21 > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/MirrorWizardPage.java > 6dfa1ca > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java > 2a75b20 > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ProcessWizardPage.java > 706328f > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ExternalFSTest.java > 0662562 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java > 9ac9f24 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceDependencyTest.java > PRE-CREATION > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java > 7f1e445 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessUpdateTest.java > PRE-CREATION > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java > 9ea8471 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDRTest.java > 1c788a3 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDbDRTest.java > a64bd6d > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/RecipeExecLocation.java > PRE-CREATION > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListProcessInstancesTest.java > be8a631 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java > b0ddcf3 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/FeedSetupTest.java > 47b1d19 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/HomePageTest.java > 20864f6 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSourceTargetOptionsTest.java > 552c15e > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorTest.java > c54789b > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ProcessSetupTest.java > 728646f > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FalconClientTest.java > d11411b > > Diff: https://reviews.apache.org/r/39391/diff/ > > > Testing > ------- > > > Thanks, > > Paul Isaychuk > >
