----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39657/#review104413 -----------------------------------------------------------
unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java (line 249) <https://reviews.apache.org/r/39657/#comment162682> For this and some other methods, I don't understand why we are creating an input stream and then extracting properties from the stream. Rather than, just creating the properties directly. unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 237) <https://reviews.apache.org/r/39657/#comment162681> The tests will be more modular and readable if we can have one test per API. I understand there is an overhead of setup for every test. If the overhead is high, you can even have a separate test class and have the setup in @BeforeClass. unit/src/test/java/org/apache/falcon/unit/examples/JavaSleepExample.java (line 29) <https://reviews.apache.org/r/39657/#comment162683> Isn't 40s a little high for UTs? This could even be a Dummy Java action, which just does a sys out and exits. Really need a sleep here? - Pallavi Rao On Oct. 28, 2015, 1:56 a.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39657/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2015, 1:56 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1528 > https://issues.apache.org/jira/browse/FALCON-1528 > > > Repository: falcon-git > > > Description > ------- > > Instance Management Api's should be supported in Falcon Unit. > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java > 91d5324 > client/src/main/java/org/apache/falcon/client/FalconClient.java 27510f6 > oozie/src/main/java/org/apache/oozie/client/LocalOozieClientCoordProxy.java > PRE-CREATION > oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java > c2100d1 > prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java > 606f741 > unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java b5afae3 > unit/src/main/java/org/apache/falcon/unit/LocalInstanceManager.java 1503b28 > unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java ac478f4 > unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 8cdbd88 > unit/src/test/java/org/apache/falcon/unit/examples/JavaSleepExample.java > PRE-CREATION > unit/src/test/resources/sleepWorkflow.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/39657/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > Narayan Periwal > >
