[
https://issues.apache.org/jira/browse/FALCON-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021095#comment-15021095
]
Ajay Yadava commented on FALCON-1607:
-------------------------------------
[~pavan kumar] I have answered all your questions on the review board.
Unfortunately, the way I replied they have appeared as another review at same
positions rather than reply to your comments(sorry about that). I didn't need
to make any changes in the patch so the patch is still valid. Let me know if
you still have any doubts.
> Code refactoring: Refactor ID into more specific sub classes
> ------------------------------------------------------------
>
> Key: FALCON-1607
> URL: https://issues.apache.org/jira/browse/FALCON-1607
> Project: Falcon
> Issue Type: Improvement
> Reporter: Ajay Yadava
> Assignee: Ajay Yadava
> Priority: Critical
> Fix For: trunk
>
> Attachments: FALCON-1607.patch
>
>
> Currently the file ID.java is used to uniquely identify various "entities"
> for native scheduler. This class is overloaded and serves multiple tasks like
> getting an entity id for an entity and an instance id for an instance.
> Keeping all this code in one class creates various issues like no check on
> object creation - one can accidentally call an instance id when the
> underlying object was supposed to be representing an entity etc. Since ID
> represents the unique identifier for an instance, entity etc. most methods
> pass ID and this makes the code hard to reason as we don't know what are we
> dealing with - an entity or an instance or something else.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
