----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41256/#review109948 -----------------------------------------------------------
pom.xml (line 120) <https://reviews.apache.org/r/41256/#comment169676> What's the rationale behind choosing this particular version? scheduler/pom.xml (line 141) <https://reviews.apache.org/r/41256/#comment169674> I think we should add support for postgres as well. scheduler/pom.xml (line 207) <https://reviews.apache.org/r/41256/#comment169677> Will it make sense to add postgres connectors as well, for users who want to use postgres? scheduler/src/main/resources/META-INF/persistence.xml (line 50) <https://reviews.apache.org/r/41256/#comment169675> How can users choose between different db backends (assuming we will add postgres support as well)? src/bin/falcon-db.sh (line 49) <https://reviews.apache.org/r/41256/#comment169673> Will logs/ directory be a better choice, so that all logs are available in one place? src/conf/startup.properties (line 55) <https://reviews.apache.org/r/41256/#comment169670> It will be useful to document a complete sample configuration for using native scheduler. src/conf/startup.properties <https://reviews.apache.org/r/41256/#comment169669> Why is FalconJPAService not required? src/conf/startup.properties (line 95) <https://reviews.apache.org/r/41256/#comment169671> Can we club this also in the commented section of application.services for native scheduler? - Ajay Yadava On Dec. 11, 2015, 11:48 a.m., pavan kumar kolamuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41256/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2015, 11:48 a.m.) > > > Review request for Falcon. > > > Bugs: https://issues.apache.org/jira/browse/FALCON-1658 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FALCON-1658 > > > Repository: falcon-git > > > Description > ------- > > Adding mysql support for Statestore db in Native Scheduler. Currently it > supports derby and it was not tested with Mysql > > > Diffs > ----- > > pom.xml 3ad8789 > scheduler/pom.xml 336997d > scheduler/src/main/resources/META-INF/persistence.xml 86558de > src/bin/falcon-db.sh 415fd5d > src/conf/startup.properties 1694930 > > Diff: https://reviews.apache.org/r/41256/diff/ > > > Testing > ------- > > Manual testing done. > > > Thanks, > > pavan kumar kolamuri > >
