> On Dec. 16, 2015, 7:29 a.m., Pallavi Rao wrote: > > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutionInstance.java, > > line 112 > > <https://reviews.apache.org/r/41401/diff/1/?file=1164741#file1164741line112> > > > > Not a good idea to expose this directly. It should remain a private > > method. If you need this to be invoked, you can add another method (rerun, > > may be) and have it invoke this.
Sure will fix > On Dec. 16, 2015, 7:29 a.m., Pallavi Rao wrote: > > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java, > > line 284 > > <https://reviews.apache.org/r/41401/diff/1/?file=1164742#file1164742line284> > > > > If we update the existing instance, we will be relying on Oozie to give > > us all the runs for an instance and details on each run. > > > > Have you evaluated this approach against creating a brand new instance > > every time and Falcon having the information that of runs and run-info? As discussed offline, We are using existing workflow it needed to run from failed actions and we will get retry count from oozie > On Dec. 16, 2015, 7:29 a.m., Pallavi Rao wrote: > > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java, > > line 286 > > <https://reviews.apache.org/r/41401/diff/1/?file=1164742#file1164742line286> > > > > You don't need to update the STATE_STORE explicitly. It is the > > responsibility of the StateService to do that (handleStateChange method). > > Just update the cache let the State transition take care of updating the > > state. Sure will fix > On Dec. 16, 2015, 7:29 a.m., Pallavi Rao wrote: > > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java, > > line 441 > > <https://reviews.apache.org/r/41401/diff/1/?file=1164742#file1164742line441> > > > > As mentioned above, create a new "trigger" method in > > ProcessExecutionInstance and have that invoke this method. Ok will fix > On Dec. 16, 2015, 7:29 a.m., Pallavi Rao wrote: > > scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java, > > line 282 > > <https://reviews.apache.org/r/41401/diff/1/?file=1164745#file1164745line282> > > > > We already have the instance, why are we retrieving it again from state > > store? > > > > If the rerun method of ProcessExecutor updates its cache, the instance > > will contain the properties. Will do > On Dec. 16, 2015, 7:29 a.m., Pallavi Rao wrote: > > scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java, > > line 286 > > <https://reviews.apache.org/r/41401/diff/1/?file=1164745#file1164745line286> > > > > Shouldn't this be FALCON_FORCE_RERUN? Yes my bad missed it > On Dec. 16, 2015, 7:29 a.m., Pallavi Rao wrote: > > scheduler/src/main/java/org/apache/falcon/state/StateService.java, line 133 > > <https://reviews.apache.org/r/41401/diff/1/?file=1164749#file1164749line133> > > > > Shouldn't this be EVENT.EXTERNAL_TRIGGER? Yes thanks for catching > On Dec. 16, 2015, 7:29 a.m., Pallavi Rao wrote: > > scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java, > > line 275 > > <https://reviews.apache.org/r/41401/diff/1/?file=1164754#file1164754line275> > > > > Add empty properties check too. Ok will add > On Dec. 16, 2015, 7:29 a.m., Pallavi Rao wrote: > > scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java, > > line 246 > > <https://reviews.apache.org/r/41401/diff/1/?file=1164757#file1164757line246> > > > > Why remove these? These shouldn't be present in the first place, right? We are rerunning by taking user params also, we are just making sure it will rerun the workflow always even though it wont be set in code. - pavan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41401/#review110629 ----------------------------------------------------------- On Dec. 15, 2015, 3:08 p.m., pavan kumar kolamuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41401/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 3:08 p.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > Currently rerun API was not supported in case of Native Scheduler in Falcon. > Rerun of instances should be implemented in FalconWorkflowEngine. > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/resource/InstancesResult.java > e05eeeb > scheduler/src/main/java/org/apache/falcon/execution/EntityExecutor.java > c9c0f42 > scheduler/src/main/java/org/apache/falcon/execution/ExecutionInstance.java > 3cc8a25 > > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutionInstance.java > f3beabc > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java > e446069 > > scheduler/src/main/java/org/apache/falcon/notification/service/event/EventType.java > 59f5cba > > scheduler/src/main/java/org/apache/falcon/notification/service/event/RerunEvent.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java > fb11091 > scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java 164fb0e > scheduler/src/main/java/org/apache/falcon/state/InstanceState.java 7f2bda9 > > scheduler/src/main/java/org/apache/falcon/state/InstanceStateChangeHandler.java > 1f69fab > scheduler/src/main/java/org/apache/falcon/state/StateService.java c702cc3 > > scheduler/src/main/java/org/apache/falcon/state/store/InMemoryStateStore.java > 2f3aa3a > > scheduler/src/main/java/org/apache/falcon/state/store/InstanceStateStore.java > f1d1931 > > scheduler/src/main/java/org/apache/falcon/state/store/jdbc/BeanMapperUtil.java > 4bee269 > > scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java > 0e3dfa9 > > scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java > b2f8e80 > scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java > e0d2a0e > > scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java > c19cada > > scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java > a26eb77 > scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java > d274ad7 > > scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java > 6d5bd49 > > webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java > f5bcc54 > > webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java > 7959b63 > webapp/src/test/resources/local-process-noinputs-template.xml aabdc6a > > Diff: https://reviews.apache.org/r/41401/diff/ > > > Testing > ------- > > > Thanks, > > pavan kumar kolamuri > >
