----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40779/#review110652 -----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java (line 324) <https://reviews.apache.org/r/40779/#comment170684> This function doesn't seem to be used anywhere. What does this function do? It seems it just changes the first output feed to new feed in datasets. falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java (line 58) <https://reviews.apache.org/r/40779/#comment170685> cluster10C , server0C? Any particular reason for this kind of naming convention? falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java (lines 96 - 110) <https://reviews.apache.org/r/40779/#comment170686> This code seems to be common across tests. Is it possible to extract it out? I am thinking it will reduce the code to core assertions and improve readability. It's ok if it is not possible to extract it out easily or it becomes too clunky. - Ajay Yadava On Nov. 27, 2015, 6:26 p.m., Karishma Gulati wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40779/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2015, 6:26 p.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > Add tests for the feature explained in > https://issues.apache.org/jira/browse/FALCON-796 - Enable users to triage > data processing issues through falcon. > As part of this patch, will add tests corresponding to single colo > processing. Cross-colo instance triage tests wil be added in a separate class > as part of a separate patch. > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java > 67d9ee2 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java > 921a303 > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java > 00ef79d > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/40779/diff/ > > > Testing > ------- > > > Thanks, > > Karishma Gulati > >
