----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41495/#review110944 -----------------------------------------------------------
scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java (line 480) <https://reviews.apache.org/r/41495/#comment170960> Shouldn't we register here as we are unregistering to ServiceRegistery in suspend ? scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java (line 213) <https://reviews.apache.org/r/41495/#comment170962> Can you add comment about parallelInstances here why is it differnt from process concurrency. In InstanceRunner we are getting process concurrency right ? scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java (line 180) <https://reviews.apache.org/r/41495/#comment170963> Same here. why it is added as perdicate, we can always get from process definition right ? - pavan kumar kolamuri On Dec. 17, 2015, 8:20 a.m., Pallavi Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41495/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2015, 8:20 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1639 > https://issues.apache.org/jira/browse/FALCON-1639 > > > Repository: falcon-git > > > Description > ------- > > Adding support entity update via native scheduler > > > Diffs > ----- > > scheduler/src/main/java/org/apache/falcon/execution/EntityExecutor.java > c9c0f42 > > scheduler/src/main/java/org/apache/falcon/execution/NotificationHandler.java > 2f68ddb > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java > e446069 > > scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java > fb11091 > scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java 164fb0e > scheduler/src/main/java/org/apache/falcon/state/InstanceState.java 7f2bda9 > > scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java > c19cada > > scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java > a26eb77 > > scheduler/src/test/java/org/apache/falcon/execution/FalconExecutionServiceTest.java > 0ddf895 > > Diff: https://reviews.apache.org/r/41495/diff/ > > > Testing > ------- > > UT added. Manual testing done. > > > Thanks, > > Pallavi Rao > >
