> On Dec. 18, 2015, 6:37 a.m., pavan kumar kolamuri wrote: > > scheduler/src/main/java/org/apache/falcon/state/InstanceState.java, line 53 > > <https://reviews.apache.org/r/41401/diff/3/?file=1168366#file1168366line53> > > > > We want to use same logic for extrenal triggers also which can be > > triggered by external service.
It is still advisable to have two different events, we can still avoid code duplication by having multiple event types in case statement or calling same methods but the flows will be much clearer and they will also be easy to separate later on if you want special handling in case of only rerun. > On Dec. 18, 2015, 6:37 a.m., pavan kumar kolamuri wrote: > > client/src/main/java/org/apache/falcon/resource/InstancesResult.java, line > > 37 > > <https://reviews.apache.org/r/41401/diff/3/?file=1168357#file1168357line37> > > > > After rerunning instances, we are displaying result with status. That > > time instance might be in Ready state. Please check in Falconworkflowengine > > rerun api. My question is not on code flow but more on conditions. For example workflow status can be waiting - when workflow is waiting for data to be available. So what is the difference between READY and waiting? Is it that it is not running because of concurrency constraints? - Ajay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41401/#review111125 ----------------------------------------------------------- On Dec. 18, 2015, 6:45 a.m., pavan kumar kolamuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41401/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2015, 6:45 a.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > Currently rerun API was not supported in case of Native Scheduler in Falcon. > Rerun of instances should be implemented in FalconWorkflowEngine. > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/resource/InstancesResult.java > e05eeeb > scheduler/src/main/java/org/apache/falcon/execution/EntityExecutor.java > c9c0f42 > scheduler/src/main/java/org/apache/falcon/execution/ExecutionInstance.java > 3cc8a25 > > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutionInstance.java > f3beabc > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java > e446069 > > scheduler/src/main/java/org/apache/falcon/notification/service/event/EventType.java > 59f5cba > > scheduler/src/main/java/org/apache/falcon/notification/service/event/RerunEvent.java > PRE-CREATION > > scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java > fb11091 > scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java 164fb0e > scheduler/src/main/java/org/apache/falcon/state/InstanceState.java 7f2bda9 > > scheduler/src/main/java/org/apache/falcon/state/InstanceStateChangeHandler.java > 1f69fab > scheduler/src/main/java/org/apache/falcon/state/StateService.java c702cc3 > > scheduler/src/main/java/org/apache/falcon/state/store/InMemoryStateStore.java > 2f3aa3a > > scheduler/src/main/java/org/apache/falcon/state/store/InstanceStateStore.java > f1d1931 > > scheduler/src/main/java/org/apache/falcon/state/store/jdbc/BeanMapperUtil.java > 4bee269 > > scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java > 0e3dfa9 > > scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java > b2f8e80 > scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java > e0d2a0e > > scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java > c19cada > > scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java > a26eb77 > scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java > d274ad7 > > scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java > 6d5bd49 > > webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java > f5bcc54 > > webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java > 7959b63 > webapp/src/test/resources/local-process-noinputs-template.xml aabdc6a > > Diff: https://reviews.apache.org/r/41401/diff/ > > > Testing > ------- > > > Thanks, > > pavan kumar kolamuri > >
