> On Dec. 18, 2015, 10:32 p.m., sandeep samudrala wrote: > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java, > > line 826 > > <https://reviews.apache.org/r/41568/diff/1/?file=1171408#file1171408line826> > > > > coordinatorJob.getAppName().startsWith("FALCON_FEED_RETENTION")
Will do it. > On Dec. 18, 2015, 10:32 p.m., sandeep samudrala wrote: > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java, > > line 828 > > <https://reviews.apache.org/r/41568/diff/1/?file=1171408#file1171408line828> > > > > return null upon if its not retention Handled null at else. > On Dec. 18, 2015, 10:32 p.m., sandeep samudrala wrote: > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java, > > line 829 > > <https://reviews.apache.org/r/41568/diff/1/?file=1171408#file1171408line829> > > > > why return null? don't consider for else at all. > > > > Return null at the end if retention coordinator not found If coord is not there then null is returned and it comes out od the function. If retention coord is found durther processing is done. > On Dec. 18, 2015, 10:32 p.m., sandeep samudrala wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java, > > line 304 > > <https://reviews.apache.org/r/41568/diff/1/?file=1171409#file1171409line304> > > > > comment is unclear. > > Do you mean > > having minutely lifecycle retention frequency. > > It would fail since lifecycle retention frequency has to be >= 1 hour. That is what I meant :) Will make it more clear. > On Dec. 18, 2015, 10:32 p.m., sandeep samudrala wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java, > > line 311 > > <https://reviews.apache.org/r/41568/diff/1/?file=1171409#file1171409line311> > > > > latearrival and cutoff not required for this test lateArrival of feed should be less than or equal to feed's retention limit. By defualt it is set to hours(6) in our template. Since its a minutely retention job so iI configured the late arrival for the same. > On Dec. 18, 2015, 10:32 p.m., sandeep samudrala wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java, > > line 361 > > <https://reviews.apache.org/r/41568/diff/1/?file=1171409#file1171409line361> > > > > same here lateArrival of feed should be less than or equal to feed's retention limit. By defualt it is set to hours(6) in our template. Since its a hourly retention job so iI configured the late arrival for the same. > On Dec. 18, 2015, 10:32 p.m., sandeep samudrala wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java, > > line 373 > > <https://reviews.apache.org/r/41568/diff/1/?file=1171409#file1171409line373> > > > > } else if (!globalWithStage) { > > same as else ? Will implement else. > On Dec. 18, 2015, 10:32 p.m., sandeep samudrala wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java, > > line 382 > > <https://reviews.apache.org/r/41568/diff/1/?file=1171409#file1171409line382> > > > > } else if (!clusterWithStage) { > > same as else ? Will implement else. > On Dec. 18, 2015, 10:32 p.m., sandeep samudrala wrote: > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java, > > line 827 > > <https://reviews.apache.org/r/41568/diff/1/?file=1171408#file1171408line827> > > > > why create coord again? Will fix. - PRAGYA ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41568/#review111281 ----------------------------------------------------------- On Dec. 18, 2015, 9:44 p.m., PRAGYA MITTAL wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41568/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2015, 9:44 p.m.) > > > Review request for Falcon and Ajay Yadava. > > > Bugs: FALCON-1567 > https://issues.apache.org/jira/browse/FALCON-1567 > > > Repository: falcon-git > > > Description > ------- > > Add test cases for https://issues.apache.org/jira/browse/FALCON-965 > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java > ae96044 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java > 8f45d1c > > Diff: https://reviews.apache.org/r/41568/diff/ > > > Testing > ------- > > Tested. > > > Thanks, > > PRAGYA MITTAL > >
