> On Dec. 21, 2015, 5:06 a.m., Pallavi Rao wrote: > > prism/src/main/java/org/apache/falcon/resource/channel/HTTPChannel.java, > > line 127 > > <https://reviews.apache.org/r/41587/diff/1/?file=1172723#file1172723line127> > > > > Generally, the web exception is thrown by the JAX-RS layer, rather than > > the resource layer.
It is available for extension and can be used for error scenarios. Falcon follows this convention to throw error messages. > On Dec. 21, 2015, 5:06 a.m., Pallavi Rao wrote: > > prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java, > > line 622 > > <https://reviews.apache.org/r/41587/diff/1/?file=1172724#file1172724line622> > > > > the catch clause for Throwable is already handling all exceptions. > > Better to change there? Both of them have different handling. > On Dec. 21, 2015, 5:06 a.m., Pallavi Rao wrote: > > prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java, > > line 880 > > <https://reviews.apache.org/r/41587/diff/1/?file=1172722#file1172722line880> > > > > Generally, the web exception is thrown by the JAX-RS layer, rather than > > the resource layer. It is available for extension and can be used for error scenarios. Falcon follows this convention to throw error messages. It is not something newly added in this JIRA. - Ajay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41587/#review111437 ----------------------------------------------------------- On Dec. 19, 2015, 9:19 a.m., Praveen Adlakha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41587/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2015, 9:19 a.m.) > > > Review request for Falcon. > > > Bugs: falcon-1565 > https://issues.apache.org/jira/browse/falcon-1565 > > > Repository: falcon-git > > > Description > ------- > > Listing API non-intuitive response if time > endTime > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/cli/FalconInstanceCLI.java 6ea34da > client/src/main/java/org/apache/falcon/client/FalconCLIException.java > 51ef952 > client/src/main/java/org/apache/falcon/client/FalconClient.java b4b1762 > prism/src/main/java/org/apache/falcon/FalconWebException.java 7324997 > prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java > da2fea7 > prism/src/main/java/org/apache/falcon/resource/channel/HTTPChannel.java > 6801398 > > prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java > 96c99f0 > > Diff: https://reviews.apache.org/r/41587/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Praveen Adlakha > >
