> On Dec. 23, 2015, 9:54 a.m., Ajay Yadava wrote: > > scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java, > > line 390 > > <https://reviews.apache.org/r/41545/diff/1/?file=1170861#file1170861line390> > > > > nit: order is actual first, expected second. Otherwise it will give > > confusing error message in case of failures.
Thanks will fix > On Dec. 23, 2015, 9:54 a.m., Ajay Yadava wrote: > > scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java, > > line 398 > > <https://reviews.apache.org/r/41545/diff/1/?file=1170861#file1170861line398> > > > > nit: order is actual first, expected second. Otherwise it will give > > confusing error message in case of failures. Will fix same here - pavan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41545/#review111763 ----------------------------------------------------------- On Dec. 18, 2015, 1 p.m., pavan kumar kolamuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41545/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2015, 1 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1640 > https://issues.apache.org/jira/browse/FALCON-1640 > > > Repository: falcon-git > > > Description > ------- > > Whenever entity is deleted corresponding instances should be deleted in > statestore. > > > Diffs > ----- > > common/src/test/java/org/apache/falcon/entity/AbstractTestBase.java a6d607b > scheduler/src/main/java/org/apache/falcon/state/store/jdbc/EntityBean.java > 03ada39 > > scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java > 0e3dfa9 > > scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java > b2f8e80 > > scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java > 6d5bd49 > > Diff: https://reviews.apache.org/r/41545/diff/ > > > Testing > ------- > > Unit testing with Derby and Manual testing with my-sql done. > > > Thanks, > > pavan kumar kolamuri > >
