----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41749/#review112202 -----------------------------------------------------------
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java (line 278) <https://reviews.apache.org/r/41749/#comment172535> nit: I think you meant "Assertion for Working Location" falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java (line 284) <https://reviews.apache.org/r/41749/#comment172543> The purpose of the function seems to validate the error message for the element. If that is the case then will some other name like "checkErrorMessageByElement" be more descriptive? falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java (line 317) <https://reviews.apache.org/r/41749/#comment172536> nit: remove the commented code please. falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java (line 398) <https://reviews.apache.org/r/41749/#comment172538> nit: remove dead code please. falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java (line 400) <https://reviews.apache.org/r/41749/#comment172537> This seems like a common requirement. Does it make sense to extract in some utility method? falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java (line 160) <https://reviews.apache.org/r/41749/#comment172539> Why is this test being disabled? falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java (line 269) <https://reviews.apache.org/r/41749/#comment172540> The description is very usefual but the BUG ID looks like reference to a private or internal issue tracking system. Can you please refer Apache JIRA instead or edit the comment? falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java (line 288) <https://reviews.apache.org/r/41749/#comment172541> The description is very usefual but the BUG ID looks like reference to a private or internal issue tracking system. Can you please refer Apache JIRA instead or edit the comment? falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-template.xml (line 42) <https://reviews.apache.org/r/41749/#comment172542> Is the notification functionality tested somewhere in these tests or is it added for future use cases? - Ajay Yadava On Dec. 28, 2015, 7:37 p.m., Paul Isaychuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41749/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2015, 7:37 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1701 > https://issues.apache.org/jira/browse/FALCON-1701 > > > Repository: falcon-git > > > Description > ------- > > HiveDr, ClusterSetupTest, MirrorSummaryTest fixes provided by Murali Ramasami > > > Diffs > ----- > > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java > bcada4a > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java > 27417bd > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java > 5efa5b2 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSummaryTest.java > 989e4b3 > > falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-template.xml > c644b99 > > falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-workflow.xml > aa4d5b0 > > falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery.properties > 99f748d > > falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-template.xml > 3afbef0 > > falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-workflow.xml > c441998 > > falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery.properties > de7f7f9 > > falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-template.xml > 3afbef0 > > falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-workflow.xml > 7362c2e > > falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure.properties > ff2611f > > Diff: https://reviews.apache.org/r/41749/diff/ > > > Testing > ------- > > tested on nightly runs > > > Thanks, > > Paul Isaychuk > >
