> On Jan. 4, 2016, 12:40 p.m., PRAGYA MITTAL wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java, > > line 96 > > <https://reviews.apache.org/r/41742/diff/2/?file=1176903#file1176903line96> > > > > One concern please, why did we change this test case. Existing > > combination is fulfilling all the scenarios as far as possible.
While 2 killed instances are enough to test the same scenario, 6 killed instances take much more time (each instances needs to be runnung, and then killed). Reducing time on this point allows us to change @BeforeClass to @BeforeMethod, which renews test precondition each time making it more stable (e.g. it guarantees that no instances are able to succeed while we need it running). > On Jan. 4, 2016, 12:40 p.m., PRAGYA MITTAL wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java, > > line 74 > > <https://reviews.apache.org/r/41742/diff/2/?file=1176903#file1176903line74> > > > > Why 2010. Consider giving a date of 2015. Copy-past one. Will address it in another jira. > On Jan. 4, 2016, 12:40 p.m., PRAGYA MITTAL wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java, > > line 244 > > <https://reviews.apache.org/r/41742/diff/2/?file=1176903#file1176903line244> > > > > Minor spelling mistake : > > check on order Thanks. Will fix it in another jira. > On Jan. 4, 2016, 12:40 p.m., PRAGYA MITTAL wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java, > > line 261 > > <https://reviews.apache.org/r/41742/diff/2/?file=1176903#file1176903line261> > > > > Does it mean we intend to list feed instances using 'list' api in this > > test case ? Agree, comment is misleading. Will fix it in another jira. - Paul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41742/#review112561 ----------------------------------------------------------- On Dec. 28, 2015, 4:05 p.m., Paul Isaychuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41742/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2015, 4:05 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1697 > https://issues.apache.org/jira/browse/FALCON-1697 > > > Repository: falcon-git > > > Description > ------- > > Fixes related to stabilization of tests which are based on instance lifecycle > by adding timeouts, separating data required for different instances etc, > optimization scenario. > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java > 3d05ae9 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java > 6493133 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceSuspendTest.java > f673314 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java > 7ad4c8e > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListProcessInstancesTest.java > 43bdd87 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/EntityPageTest.java > 4ad775e > > Diff: https://reviews.apache.org/r/41742/diff/ > > > Testing > ------- > > Testing done. > > > Thanks, > > Paul Isaychuk > >
