----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41852/#review113011 -----------------------------------------------------------
Ship it! Good to go once you have addressed the minor refactor pointed out. prism/src/main/java/org/apache/falcon/FalconWebException.java (line 57) <https://reviews.apache.org/r/41852/#comment173493> This method can call newAPIException(message, status) with BAD_REQUEST as status - Pallavi Rao On Jan. 5, 2016, 7:40 p.m., Praveen Adlakha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41852/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2016, 7:40 p.m.) > > > Review request for Falcon. > > > Bugs: Falcon-1705 > https://issues.apache.org/jira/browse/Falcon-1705 > > > Repository: falcon-git > > > Description > ------- > > Standardization of error handling in falcon Server > > > Diffs > ----- > > prism/src/main/java/org/apache/falcon/FalconWebException.java 0b6c38e > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java > 0ea2e4e > prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java > d50d111 > > prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java > 88131f3 > prism/src/main/java/org/apache/falcon/resource/channel/HTTPChannel.java > 41be13f > > prism/src/main/java/org/apache/falcon/resource/metadata/LineageMetadataResource.java > 8c5346f > > prism/src/main/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResource.java > 60c1089 > prism/src/main/java/org/apache/falcon/resource/proxy/BufferedRequest.java > 85041f9 > > prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java > 801bd10 > > prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java > dfed5af > > webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java > 0c7786f > > Diff: https://reviews.apache.org/r/41852/diff/ > > > Testing > ------- > > [INFO] Apache Falcon ...................................... SUCCESS [05:13 > min] > [INFO] Apache Falcon UI ................................... SUCCESS [ 0.027 > s] > [INFO] Checkstyle ......................................... SUCCESS [ 0.005 > s] > [INFO] Build Tools ........................................ SUCCESS [ 0.009 > s] > [INFO] Apache Falcon Java client .......................... SUCCESS [ 0.095 > s] > [INFO] Apache Falcon CLI client ........................... SUCCESS [ 0.012 > s] > [INFO] Apache Falcon Metrics .............................. SUCCESS [ 0.013 > s] > [INFO] Apache Falcon Hadoop Dependencies .................. SUCCESS [ 0.027 > s] > [INFO] Apache Falcon Test Utility ......................... SUCCESS [ 0.009 > s] > [INFO] Apache Falcon Commons .............................. SUCCESS [ 0.100 > s] > [INFO] Apache Falcon Oozie EL Extension ................... SUCCESS [ 0.015 > s] > [INFO] Apache Falcon Embedded Hadoop - Test Cluster ....... SUCCESS [ 0.077 > s] > [INFO] Apache Falcon Sharelib Hive - Test Cluster ......... SUCCESS [ 0.006 > s] > [INFO] Apache Falcon Sharelib Pig - Test Cluster .......... SUCCESS [ 0.008 > s] > [INFO] Apache Falcon Sharelib Hcatalog - Test Cluster ..... SUCCESS [ 0.006 > s] > [INFO] Apache Falcon Sharelib Oozie - Test Cluster ........ SUCCESS [ 0.008 > s] > [INFO] Apache Falcon Test Tools - Test Cluster ............ SUCCESS [ 0.003 > s] > [INFO] Apache Falcon Messaging ............................ SUCCESS [ 0.018 > s] > [INFO] Apache Falcon LIfecycle Module ..................... SUCCESS [ 0.072 > s] > [INFO] Apache Falcon Oozie Adaptor ........................ SUCCESS [ 0.066 > s] > [INFO] Apache Falcon Scheduler ............................ SUCCESS [ 0.061 > s] > [INFO] Apache Falcon Acquisition .......................... SUCCESS [ 0.012 > s] > [INFO] Apache Falcon Distcp Replication ................... SUCCESS [ 0.013 > s] > [INFO] Apache Falcon Retention ............................ SUCCESS [ 0.008 > s] > [INFO] Apache Falcon Archival ............................. SUCCESS [ 0.007 > s] > [INFO] Apache Falcon Rerun ................................ SUCCESS [ 0.019 > s] > [INFO] Apache Falcon Prism ................................ SUCCESS [ 0.623 > s] > [INFO] falcon-unit ........................................ SUCCESS [ 0.016 > s] > [INFO] Apache Falcon Web Application ...................... SUCCESS [ 0.165 > s] > [INFO] Apache Falcon Documentation ........................ SUCCESS [ 0.025 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 05:17 min > [INFO] Finished at: 2016-01-02T22:02:42+05:30 > [INFO] Final Memory: 598M/1415M > > > Thanks, > > Praveen Adlakha > >
