> On Jan. 6, 2016, 2:14 a.m., Sowmya Ramesh wrote: > > scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java, > > line 255 > > <https://reviews.apache.org/r/41922/diff/2/?file=1181920#file1181920line255> > > > > Minor nit: This code can actually go in else if part of line 244. Will > > make it more readable. Why can't this check be done on props instead of > > jobprops?
Suppose user rerun the process instance with oozie.wf.rerun.skip.nodes and later he rerun's with just force option, since force option is there we are adding oozie.wf.rerun.failnodes in props and merging with jobprops, but jobprops will contain oozie.wf.rerun.skip.nodes because of previous rerun which lead to rerun failure of that instance as both props exist. Thats why it was not added in else if and checked in jobprops instead of props. - pavan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41922/#review112994 ----------------------------------------------------------- On Jan. 5, 2016, 12:51 p.m., pavan kumar kolamuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41922/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2016, 12:51 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1720 > https://issues.apache.org/jira/browse/FALCON-1720 > > > Repository: falcon-git > > > Description > ------- > > Falcon rerun not working as expected in few cases > > > Diffs > ----- > > > scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java > 1425a97 > > webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java > f053b76 > > webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java > 1523b76 > webapp/src/test/resources/local-process-noinputs-template.xml aabdc6a > > Diff: https://reviews.apache.org/r/41922/diff/ > > > Testing > ------- > > > Thanks, > > pavan kumar kolamuri > >
