[
https://issues.apache.org/jira/browse/FALCON-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091840#comment-15091840
]
Ajay Yadava commented on FALCON-1735:
-------------------------------------
Committed to master.
Commit id: 26531b5
> FalconException shouldn't be caught in AbstractRerunHandler in case of
> obtaining Workflow engine from entity
> ------------------------------------------------------------------------------------------------------------
>
> Key: FALCON-1735
> URL: https://issues.apache.org/jira/browse/FALCON-1735
> Project: Falcon
> Issue Type: Bug
> Reporter: pavan kumar kolamuri
> Assignee: pavan kumar kolamuri
> Fix For: 0.9
>
> Attachments: FALCON-1735.patch
>
>
> WorkflowEngineFactory.getWorkflowEngine(Entity entity) throw FalconException
> in three cases
> 1) When it didnt find org.apache.falcon.workflow.engine.FalconWorkflowEngine
> this class in class path
> 2) When StateStore is not initialized
> 3) FalconException will be thrown if entity is not present in configStore.
> I thought when org.apache.falcon.workflow.engine.FalconWorkflowEngine doesn't
> exists its better to return defaultworkflowengine but looks like it might not
> occur since FalconWorkflowEngine will be present always from now .
> Second case is not possible it won't throw FalconException it might throw
> other runtime exceptions
> Third case won't occur generally but still we shouldn't catch exception and
> return Default WorkflowEngine.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
