----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42064/#review114947 -----------------------------------------------------------
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java (line 280) <https://reviews.apache.org/r/42064/#comment175777> bundles is a Map and does not have a removeAll method. Had it been a collection, could have done that. - Pallavi Rao On Jan. 8, 2016, 11 a.m., Pallavi Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42064/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2016, 11 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1662 > https://issues.apache.org/jira/browse/FALCON-1662 > > > Repository: falcon-git > > > Description > ------- > > Some problems that were identified while testing this have been fixed: > 1. OozieWorkflowEngine isActive method had an issue. > 2. The JDBCStateStore was not filtering by cluster. > > Additionally, noted that update was not compliant with oozie scheduler and > fixed it. > > > Diffs > ----- > > > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java > cf0e30d > > scheduler/src/main/java/org/apache/falcon/execution/FalconExecutionService.java > f45ec98 > > scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java > 5ed3ccd > > scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java > abd4119 > > scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java > c9e6da4 > > scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java > bb8ff61 > > Diff: https://reviews.apache.org/r/42064/diff/ > > > Testing > ------- > > UTs updated. Manual testing done. > > > Thanks, > > Pallavi Rao > >
