Hi, In my opinion its a better approach. +1 from my end.
Thanks On Thu, Jan 21, 2016 at 1:19 PM, Ajay Yadav <[email protected]> wrote: > Hello everyone, > > Several projects in Apache (the cool kids on the block like SPARK, flink > etc.) have moved to github's pull request model instead of the patch and > review board approach and more are moving towards that approach. I > personally find this approach much better and some of the advantages are as > follows > > 1. *Familiarity* *-* Due to the popularity of github in open source > projects lot more users are familiar with the pull request model than > the > patch based approach. > 2. *Ease - *Users don't have to create a review board request and at the > same time attach the patch to JIRA also. Committers can easily commit a > patch with the click of a button. > 3. *Conflicts - *Users get a real time visibility in whether their > contribution has conflicts. > 4. *Attribution - *Github's Pull request model allows a stronger > attribution for the contribution as the author of the patch is the user > who > submitted the pull request and not the committer who committed this to > master. > > > This will require some preparation work to be done beforehand for example > pre commit builds etc. to be configured. If no one has any concerns then I > can start figuring out the details and setting infrastructure for it. > Thoughts, suggestions and tips are welcome :) > > > Cheers > Ajay Yadava > -- _____________________________________________________________ The information contained in this communication is intended solely for the use of the individual or entity to whom it is addressed and others authorized to receive it. It may contain confidential or legally privileged information. If you are not the intended recipient you are hereby notified that any disclosure, copying, distribution or taking any action in reliance on the contents of this information is strictly prohibited and may be unlawful. If you have received this communication in error, please notify us immediately by responding to this email and then delete it from your system. The firm is neither liable for the proper and complete transmission of the information contained in this communication nor for any delay in its receipt.
