----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42455/#review115828 -----------------------------------------------------------
scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java (line 159) <https://reviews.apache.org/r/42455/#comment176896> IMO we should ideally be doing two catches here one for EntityNotRegisteredException which will print the exception in log and other catch statement will catch FalconException and will do nothing. - Praveen Adlakha On Jan. 22, 2016, 11:29 a.m., Pallavi Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42455/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2016, 11:29 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1754 > https://issues.apache.org/jira/browse/FALCON-1754 > > > Repository: falcon-git > > > Description > ------- > > The Service should continue to notify other handlers on exception > > > Diffs > ----- > > > scheduler/src/main/java/org/apache/falcon/execution/FalconExecutionService.java > 7bdcd6f > > scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java > 4278d3f > > Diff: https://reviews.apache.org/r/42455/diff/ > > > Testing > ------- > > > Thanks, > > Pallavi Rao > >
