----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42693/#review116042 -----------------------------------------------------------
scheduler/src/main/java/org/apache/falcon/execution/FalconExecutionService.java (line 232) <https://reviews.apache.org/r/42693/#comment177056> Ideally should have an onKill method in EntityStateChangeHandler and that must get invoked. In this method, we are doing a state change for every cluster, which is not required. scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java (line 252) <https://reviews.apache.org/r/42693/#comment177057> Unregistering later might be an issue, coz., some state changes may be attempted because of lets the SchedulerService attempting to schedule an instance that has been killed. - Pallavi Rao On Jan. 24, 2016, 6:16 a.m., pavan kumar kolamuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42693/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2016, 6:16 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1758 > https://issues.apache.org/jira/browse/FALCON-1758 > > > Repository: falcon-git > > > Description > ------- > > Currently delete API will cause inconsistencies when Falcon restarts. Fixed > all those inconsistencies by added new state called killed. > > > Diffs > ----- > > > scheduler/src/main/java/org/apache/falcon/execution/FalconExecutionService.java > da1d7cc > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java > 188cec2 > scheduler/src/main/java/org/apache/falcon/state/EntityState.java ae57fa1 > scheduler/src/main/java/org/apache/falcon/state/StateService.java 9266354 > > scheduler/src/main/java/org/apache/falcon/state/store/AbstractStateStore.java > 84d12f8 > > Diff: https://reviews.apache.org/r/42693/diff/ > > > Testing > ------- > > Tested all basic scenarios. > > > Thanks, > > pavan kumar kolamuri > >
